fetch a distribution file using the git commit

[Carlos J Puga Medina]

On Sun, 2015-08-30 at 19:04 +0930, Shane Ambler wrote:
> On 29/08/2015 18:53, Carlos J Puga Medina wrote:
> > > It works for me as expected, but is this line from the 
> > > configuration
> > > file? if yes, it should have "":
> > 
> > > MASTER_SITES_tl-parser="
> > https://codeload.github.com/vysheng/tl-parser/tar.gz/1659d87?dummy=
> > "
> > 
> > No. The MASTER_SITES is set by GH_* variables.
> 
> That's not from the makefile, it is the output during the fetch 
> stage.
> 
> > See for details:
> > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-dist
> > file
> > s.html#makefile-master_sites-github
> > 
> > > not found
> > > *** Error code 127
> > > 
> > > Here it is the relevant part in the Makefile
> > > USE_GITHUB=     yes
> > > GH_ACCOUNT=     vysheng
> > > GH_PROJECT=     tgl:tgl tl-parser:tl-parser
> > > GH_TAGNAME=     2.0.1:tgl 1659d87:tl-parser
> > > 
> 
> Yes using multiple github groups has been working for a couple of
> months now and they had me stumped at first too, you need two small
> changes.
> 
> The first is that you must use the default group, this is misleading 
> as
> the example in the porters handbook matches what you have done and 
> the
> non-github use of groups does not enforce a default group. In the
> second paragraph to 5.4.3.1 it does say "The main value can either 
> have
> no tag, or the :DEFAULT tag" - so you should remove the usage of :tgl
> - not specifying a group name implies :DEFAULT
> 
> The second issue is that the group name does not like the '-' sign in
> the name. As detailed under 5.4.8.2 - "Elements can be postfixed with
> :n where n is [^:,]+, that is, n could conceptually be any 
> alphanumeric
> string but we will limit it to [a-zA-Z_][0-9a-zA-Z_]+ for now."
> 
> This leads to the following to get it working -
> 
> USE_GITHUB=     yes
> GH_ACCOUNT=     vysheng
> GH_PROJECT=     tgl tl-parser:tlparser
> GH_TAGNAME=     2.0.1 1659d87:tlparser
> 
> 
> While the porters handbook has been updated since I suggested some
> changes I think it could still be improved a little.
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=172964
> 

I didn't have any idea about this change. Now it can fetch properly all
distribution files.  

Thanks, Shane!
-- 
Carlos Jacobo Puga Medina <cpm at fbsd.es>
PGP fingerprint = C60E 9497 5302 793B CC2D  BB89 A1F3 5D66 E6D0 5453
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-questions/attachments/20150830/ffe761b4/attachment.bin>