spamassassin Y2010 bug

[Matthew Seaman]

Matt Emmerton wrote:
>> On Sun, 03 Jan 2010 20:10:19 +0000
>> Matthew Seaman <m.seaman at infracaninophile.co.uk> wrote:
>>
>>> Comments, critique are welcome.  Unless there are any killer bugs,
>>> I'll send-pr(1) in a week or so.
>>
>> You have:
>>
>> : ${daily_sa_compile="YES"}
>>
>> sa-compile is installed by the SA port, but it requires devel/re2c,
>> which is an optional dependency. With a standard install your script
>> will update the rules, the compile will unconditionally fail, and so
>> spamd won't get restarted.
>>
>> You could detect the re2c port, but I think it would be better to turn
>> it off by default

Hmmm... good point.  

>> I'd also suggest running sa-compile with nice  by default.
> 
> I've put up a set of diffs (patches) in shar format that address some of 
> these issues:
> 
> 1) re2c is listed as a run dependency.  No two ways around it - if you 
> do plan on running sa-compile at some time, you'll need re2c, and 
> chances are that the machine that is running sa-update is also going to 
> be running sa-compile.

Yes.  Agreed.  
 
> 2) sa-compile is nice(1)'d by default, and you can provide other flags 
> to nice(1) as well.

This is a good idea too.
 
> See http://www.gsicomp.on.ca/~matt/sa-utils-patches.shar

I'll add your patches and post an updated shar later on.

Thank you all very much for your comments.

	Cheers,

	Matthew

-- 
Dr Matthew J Seaman MA, D.Phil.                   7 Priory Courtyard
                                                  Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey     Ramsgate
                                                  Kent, CT11 9PW

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-questions/attachments/20100104/b47d06c5/signature.pgp