another compile error

[Kent Stewart]

On Tuesday 09 June 2009 09:54:41 am Valentin Bud wrote:
> On Tue, Jun 9, 2009 at 7:42 PM, Kent Stewart <kstewart at owt.com> wrote:
> > On Tuesday 09 June 2009 08:00:20 am DA Forsyth wrote:
> > > Hiya
> > >
> > > trying to build kernel for 7.2 and get this
> > > (my earlier problem was my having CFLAGS=... in /etc/src.conf)
> > >
> > > MAKE=make sh /usr/src/sys/conf/newvers.sh LERGY72
> > > cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -
> > > Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -
> > > Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -
> > > I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -
> > > DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -
> > > finline-limit=8000 --param inline-unit-growth=100 --param large-
> > > function-growth=1000  -mno-align-long-strings -mpreferred-stack-
> > > boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -
> > > ffreestanding -Werror  vers.c
> > > linking kernel.debug
> > > udbp.o(.text+0x59): In function `ng_udbp_disconnect':
> > > /usr/src/sys/dev/usb/udbp.c:857: undefined reference to
> > > `ng_rmnode_self'
> > > udbp.o(.text+0xc9): In function `udbp_detach':
> > > /usr/src/sys/dev/usb/udbp.c:450: undefined reference to
> > > `ng_rmnode_self'
> > > udbp.o(.text+0xde):/usr/src/sys/dev/usb/udbp.c:452: undefined
> > > reference to `ng_unref_node'
> > > udbp.o(.text+0x79e): In function `udbp_attach':
> > > /usr/src/sys/dev/usb/udbp.c:375: undefined reference to `ng_newtype'
> > > udbp.o(.text+0x7cc):/usr/src/sys/dev/usb/udbp.c:381: undefined
> > > reference to `ng_make_node_common'
> > > udbp.o(.text+0x813):/usr/src/sys/dev/usb/udbp.c:384: undefined
> > > reference to `ng_name_node'
> > > udbp.o(.text+0x828):/usr/src/sys/dev/usb/udbp.c:385: undefined
> >
> > I just cvsuped and did a buildworld and a buildkernel. The kernel
> > compiled without a problem. So, this means that you have probably
> > modified your kernel
> > config file until it doesn't work. Start over with GENERIC and leave the
> > comment on udbp.
> >
> > Kent
> >
> > --
> > Kent Stewart
> > Richland, WA
> >
> > http://users.owt.com/kstewart/index.html
> >
> > _______________________________________________
> > freebsd-questions at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-questions
> > To unsubscribe, send any mail to "
> > freebsd-questions-unsubscribe at freebsd.org"
>
> Hello,
>
>  If you want udbp(4) you have to know that it requires netgraph(4).
> They are both available as modules and/or kernel config options
> (actually udbp(4) is a device :) ).

If that is all it takes, then, I think that GENERIC should mention 
the "options NETGRAPH" as a requirement for udbp. There are numerous places 
with "requires miibus" as a comment because a device won't compile without 
it. A commented line has often been there because it was a work in progress 
such as ULE was for what seems like years or broken for unknown reasons. 
GENERIC was always self documenting.

Kent

-- 
Kent Stewart
Richland, WA

http://users.owt.com/kstewart/index.html