sorta newb help compiling samba

Polytropon freebsd at edvax.de
Fri Apr 10 12:44:23 PDT 2009


Just a small sidenote according to your shell script:

You're defining

	# echo without newline
	necho () {
		echo "$*" | tr -d '\012'
	}

Why don't you use echo -n which suppresses the newline instead
of involving another program to do something that echo can do
on its own? This is how FreeBSD does it in its system scripts.

	echo -n "Starting service... "
	start_service
	echo "done."

And according to 

	test -d /usr/bin || exit 0	# /usr not mounted

Woudln't it be more compliant to exit 1 to signal an error
due to /usr not being mounted? Exit code 0 is usually used
to signal that no error has happened (successful program
run), which isn't the case when the script is not (completely)
run.



-- 
Polytropon
>From Magdeburg, Germany
Happy FreeBSD user since 4.0
Andra moi ennepe, Mousa, ...


More information about the freebsd-questions mailing list