pkg_fetch fetches from wrong place???

[Webster, Andrew]

> -----Original Message-----
> From: Kris Kennaway [mailto:kris at obsecurity.org]
> Sent: Friday, March 03, 2006 12:19
> To: Webster, Andrew
> Cc: freebsd-questions at freebsd.org
> Subject: Re: pkg_fetch fetches from wrong place???
> 
> On Fri, Mar 03, 2006 at 09:46:20AM -0500, Webster, Andrew wrote:
> > I'm trying to figure out how pkg_fetch decides where to get packages
> > from.
> 
> Check the source code :-)

I'm no ruby expert, but the logic looks pretty dubious to me.
The decision to choose the latest is based on whether or not there is a
dash (-) in the filename.  (Line 169 of pkg_fetch).
As a result,
Postgresql74-server sets latest to false.  
Postgresql74 sets latest to true, however there is no such thing as
postgresql74 in packages, it is either -client or -server, etc.
I think the author was intending to use the - to indicate the beginning
of a version number, but that logic is somewhat flawed given the package
naming conventions.