My ppp.conf looks like this:
default:
qdsl:
nat enable yes
set device PPPoE:fxp1
add! default HISADDR
set authname <username>
set authkey <password>
Maybe the missing "!" after the "add" keyword is the solution to your
problem.
Björn