[patch] environment variable EDITOR is set wrong in fixit mode

[John Baldwin]

On Saturday 15 April 2006 03:18, BjXrn KXnig wrote:
> 
> >Submitter-Id:	current-users
> >Originator:	Björn König
> >Organization:	
> >Confidential:	no 
> >Synopsis:	[patch] environment variable EDITOR is set wrong in fixit mode
> >Severity:	non-critical
> >Priority:	medium
> >Category:	misc
> >Class:		change-request
> >Release:	FreeBSD 6.1-RC i386
> >Environment:
> System: FreeBSD hoppel.local 6.1-RC FreeBSD 6.1-RC #0: Fri Apr 14 20:32:06 CEST 2006 bkoenig at hoppel.local:/home/bkoenig/obj/home/bkoenig/devel/freebsd/RELENG_6_1/src/sys/HOPPEL i386
> >Description:
> 	If you start the fixit mode of disc1 then the
> 	environment variable EDITOR is set wrong. Its
> 	value is /mnt2/stand/vi, but vi doesn't exist
> 	at this place.
> 
> 	This concerns the variable PAGER likewise.
> 	
> >How-To-Repeat:
> 	Go to fixit mode:
> 
> 	Fixit# $EDITOR
> 	/mnt2/stand/vi: not found
> 
> >Fix:
> 	There are at least two possible solutions.
> 
> 	First of all /mnt2/stand is a symlink to /rescue,
> 	but /rescue doesn't exist. It migth be better to
> 	create a symlink to "rescue" instead of "/rescue".
> 	In this case /mnt2/stand would be a symlink to
> 	"rescue", i.e. /mnt2/rescue becomes the real path.
> 	EDITOR don't need to be changed and vi works. PAGER
> 	still doesn't work, because more doesn't exist
> 	in rescue.
> 
> 	A second approach would be to simply change EDITOR to
> 	/mnt2/usr/bin/vi resp. PAGER to /mnt/usr/bin/more.
> 
> 	These two patches deals with the issue. You may
> 	apply both patches.

I think the first patch is better and EDITOR should be
unchanged.  Perhaps the PAGER should be set only if
/mnt2/usr/bin/more exists?  If you use the fixit floppy
instead of the CD I think it won't exist.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org