[Bug 240375] [NEW PORT] www/py-isso: A commenting server similar to Disqus

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240375

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |python at FreeBSD.org,
                   |                            |rt at scientifics.de
              Flags|                            |maintainer-feedback?(rt at sci
                   |                            |entifics.de)
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thank you for your new port submission René

There's a number of review items that need to be taken care of, so it would be
great if you could run the port through QA (portlint, and poudriere in
particular). 

For more details and instructions see:
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

At a quick glance:

- Remove "A " from COMMENT (portlint should complaint about this)
- COMMENT for Python ports should match setup.py:description with portlint
compliant changes where necessary (COMMENT=Lightweight Disqus alternative)
- Use GH_* variables (eg: GH_TAGNAME) not COMMIT_ID
- Use MASTER_SITES=CHEESESHOP unless there is a compelling temporary reason to
use an alternative source (like GitHub), such as missing test or test data
files.
- Add python as a secondary CATEGORIES
- NO_ARCH is out of order (put it after USES, portlint should complain about
this)
- Dont hardcode paths (like /usr/local/etc), as people can change their PREFIX.
Use ${ETCDIR} instead)
- cffi is missing as a BUILD_DEPENDS (setup_requires=["cffi>=1.3.0"],)
- conditional Python 2.7 dependencies are missing (':python_version=="2.7"':
['ipaddr>=2.1', 'configparser']) - Note: these should be moved in upstream code
to install_requires with environment markers, they are not optional for
python2.7)
- For all *_DEPENDS, match the version specifiers are closely as possible.
RUN_DEPENDS currently specify >0, but setup.py says, for example:

misaka>=2.0,<3.0'
werkzeug>=0.9
ipaddr>=2.1'

-- 
You are receiving this mail because:
You are on the CC list for the bug.