[Bug 242997] games/oolite: Fix build for Python 3.x

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242997

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210343|0                           |1
        is obsolete|                            |

--- Comment #3 from lightside <lightside at gmx.com> ---
Created attachment 210354
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=210354&action=edit
Proposed patch (since 520894 revision)

- Cosmetic changes.

Hello, Kubilay Kocak.

(In reply to Kubilay Kocak from comment #2)
> Could you please:
> 
>  - Submit this patch upstream as an issue or pull request, and include the
> issue/PR URL in the See Also field
Sorry, but I can't (or not interested). There is no patch. There are only
(temporary) dynamic changes with using 2to3 script, provided by Python
installation.
But if remove "--no-diffs" option for invocation of 2to3 script, it shows
changes for usage of print function:
-8<--
RefactoringTool: Skipping optional fixer: buffer
RefactoringTool: Skipping optional fixer: idioms
RefactoringTool: Skipping optional fixer: set_literal
RefactoringTool: Skipping optional fixer: ws_comma
RefactoringTool: Refactored imacro_asm.py
--- imacro_asm.py       (original)
+++ imacro_asm.py       (refactored)
@@ -456,7 +456,7 @@
 if __name__ == '__main__':
     import sys
     if len(sys.argv) != 3:
-        print "usage: python imacro_asm.py infile.jsasm outfile.c.out"
+        print("usage: python imacro_asm.py infile.jsasm outfile.c.out")
         sys.exit(1)

     f = open(sys.argv[2], 'w')
RefactoringTool: Refactored build/cl.py
--- build/cl.py (original)
+++ build/cl.py (refactored)
@@ -51,7 +51,7 @@
             break

     if target == None:
-        print >>sys.stderr, "No target set" and sys.exit(1)
+        print("No target set" and sys.exit(1), file=sys.stderr)

     # The deps target lives here
     depstarget = os.path.basename(target) + ".pp"
@@ -90,7 +90,7 @@

     f = open(depstarget, "w")
     for dep in sorted(deps):
-        print >>f, "%s: %s" % (target, dep)
+        print("%s: %s" % (target, dep), file=f)

 if __name__ == "__main__":
     InvokeClWithDependencyGeneration(sys.argv[1:])
RefactoringTool: Files that were modified:
RefactoringTool: imacro_asm.py
RefactoringTool: build/cl.py
-->8-

Also, the custom version of SpyderMonkey is just a external dependency for
OOlite, if looking for source code:
https://github.com/OoliteProject/oolite/tree/1.88/deps
https://github.com/OoliteProject/spidermonkey-ff4/blob/ca2fb5423fab4d72a3dc5fec911ce20bda01f223/README.txt

I guess, if developers may want to support Python 3.x version, they can do this
with using 2to3 script, if needed. There is no defect and it normally works
with using Python 2.x version. This is just a build dependency.

> - Confirm that this change passes QA (poudriere)
It passes build with using Python 3.x version:
-8<--
% make PYTHON_VERSION=3.6 clean check-plist
<..>
Configuring Javascript library...

mkdir -p deps/mozilla/js/src/build-release
<..>
checking for python2.7... (cached) /usr/local/bin/python3.6
<..>
checking for Python version >= 2.5... yes
<..>
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
-->8-

> Please include an update to the MAINTAINER line if you can
Thanks, but I interested in this PR only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.