[Bug 190065] New port: net-p2p/py-transmission-remote-curses Remote Curses UI for Transmission daemon

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190065

--- Comment #4 from Jan Beich <jbeich at vfemail.net> ---
> MASTER_SITES=  https://codeload.github.com/${GH_ACCOUNT}/${GH_PROJECT}/legacy.tar.gz/v${PORTVERSION}?dummy=/
> DISTNAME=      ${GH_PROJECT}-v${PORTVERSION}

No need to specify those with USE_GITHUB. Instead put

  GH_TAGNAME=    v${DISTVERSION}

and re-fetch the distfile.

> PKGNAMEPREFIX=  ${PYTHON_PKGNAMEPREFIX}

Don't define unless the port installs files under PYTHON_SITELIBDIR or at least
allows generating *non-conflicting* packages for different python versions.

> USE_PYTHON=     YES

Convert to USES=python,run

> NO_BUILD=       yes

Define NO_ARCH as well unless the port installs binaries for a specific ARCH.

>        ${INSTALL_SCRIPT} ${WRKSRC}/transmission-remote-cli ${STAGEDIR}${BINDIR}/${PORTNAME}

Wrap long lines to fit on 80 characters terminal.

> OPTIONS_DEFINE= ADNS GEOIP

ADNS_DESC is not defined anywhere.

> #LIB_DEPENDS+=  ${PYTHON_SITELIBDIR}/adns.so:${PORTSDIR}/dns/py-adns
> LIB_DEPENDS+=   libadns.so:${PORTSDIR}/dns/py-adns
...
> #LIB_DEPENDS+=  ${PYTHON_SITELIBDIR}/GeoIP.so:${PORTSDIR}/net/py-GeoIP
> LIB_DEPENDS+=   libGeoIP.so:${PORTSDIR}/net/py-GeoIP

Use RUN_DEPENDS and convert to option helpers, see Mk/bsd.options.mk or
net/py-kombu/Makefile for an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.