Simple change into Mk/bsd.python.mk

Li-Wen Hsu lwhsu at FreeBSD.org
Sun Sep 2 10:03:12 UTC 2012


On Sun, Sep 2, 2012 at 3:31 PM, Ruslan Mahmatkhanov <cvs-src at yandex.ru> wrote:
> Hi,
>
> I'm preparing an update of www/plone and discovered thing that's need to be
> changed to make USE_ZOPE knob actually work. We do not define ZOPESKELDIR
> anymore, so the RUN_DEPENDS line should be fixed.
> While here, trim some leftover from py24/25 removal, that's now always true
> in current ports tree. Would you please approve this change?
>
> PS. It doesn't needed an exp-run because at the time there is no ports, that
> use USE_ZOPE.

Looks good to me, and if you don't mind, how about doing this:

    RUN_DEPENDS+=	${LOCALBASE}/bin/zopectl:${ZOPE_PORTSDIR}

in this way:

    RUN_DEPENDS+=	zope213>0:${ZOPE_PORTSDIR}

or even replace this:

    ZOPE_PORTSDIR=	${PORTSDIR}/www/zope213

with:

    ZOPE_DEPENDS=	zope213>0:${PORTSDIR}/www/zope213

and then, .if defined(USE_ZOPE) section can be written as:

    RUN_DEPENDS+=	${ZOPE_DEPENDS}

How do you think?

-- 
Li-Wen Hsu
http://lwhsu.org


More information about the freebsd-python mailing list