[Bug 241974] lang/nim: Remove BROKEN for powerpc64

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Nov 24 12:28:28 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241974

--- Comment #11 from Piotr Kubaj <pkubaj at FreeBSD.org> ---
There are still several issues.

There is another include of bsd.port.pre.mk, which itself breaks build.

It will be much cleaner to do it like:
.if defined(PPC_ABI) && ${PPC_ABI} == ELFv2
EXTRA_PATCHES=${PATCHDIR}/elfv2-patch
.else
EXTRA_PATCHES=${PATCHDIR}/elfv1-patch
.endif

Such approach is clean and makes it easy to see what you do.

In post-patch, you check for PPC_ABI, but this is only defined on powerpc64,
which will break build on anything else.
You could check like:
.if defined(PPC_ABI) && ${PPC_ABI} == ELFv2 (or 1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ppc mailing list