[Bug 233863] r345425 on PowerMac G5 may require kern.smp.disabled=1 and must set usefdt=1 which causes net interface reorder

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233863

--- Comment #11 from Mark Millard <marklmi26-fbsd at yahoo.com> ---
(In reply to Mark Millard from comment #10)

The disabling of blocking duplicate paths in fdt_add_subnode_namelen
was done incorrectly. I'll replace the attachment after building
and testing. I think this is the explanation for the PowerMac11,2
shutdown -r or -p problems.

The code should have just disabled the return, more like:

        if (offset >= 0)
#if 0
// Some Macintoshes have identical package-to-pathname results for
// multiple nodes of the same type and unit under the parent node.
// Avoid blocking this for fdt.
                return -FDT_ERR_EXISTS;
#else
                ;
#endif
        else if (offset != -FDT_ERR_NOTFOUND)
                return offset;

Instead the messed up change did the "return offset;" and
so did not do the addition of the node, instead returning
the pre-existing one to be manipulated.

-- 
You are receiving this mail because:
You are the assignee for the bug.