[Bug 233579] ppc64 r341455 will panic on boot with usefdt=1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233579

--- Comment #8 from Dennis Clarke <dclarke at blastwave.org> ---
Minor correction .. printf ("%p",foo) has a snit if foo isn't a 64bit data
element similar to a pointer thus : 

*** sys/powerpc/powermac/macgpio.c.orig Tue Dec  4 23:52:41 2018
--- sys/powerpc/powermac/macgpio.c      Wed Dec  5 14:31:30 2018
***************
*** 161,169 ****
--- 161,171 ----
          phandle_t root, child, iparent;
          device_t cdev;
        uint32_t irq;
+       printf("DEBUG : in %s at %d\n",__FILE__, __LINE__);

        sc = device_get_softc(dev);
        root = sc->sc_node = ofw_bus_get_node(dev);
+       printf("DEBUG : in %s at %d\nDEBUG : root = sc->sc_node = %p\n",
__FILE__, __LINE__, (void *)((uint64_t)root));

        sc->sc_gpios = bus_alloc_resource_any(dev, SYS_RES_MEMORY,
            &sc->sc_gpios_rid, RF_ACTIVE);

Ugly but it works. 

I think phandle_t is a uint32_t and so a trivial %x could have done the job. 

Regardless we now know that the problem is not in macgpio.c and must move
onwards to smu.

-- 
You are receiving this mail because:
You are the assignee for the bug.