[PATCH] Switch ofw_console(4) to callout(9)

[Alexey Dokuchaev]

On Thu, Aug 28, 2014 at 09:14:23PM -0400, John Baldwin wrote:
> On Aug 28, 2014, at 2:44 AM, Alexey Dokuchaev <danfe at FreeBSD.ORG> wrote:
> > On Mon, Aug 25, 2014 at 03:39:20PM -0400, John Baldwin wrote:
> >> This patch switches the ofw_console driver from timeout(9) to callout(9).
> >> The patch is against HEAD but it probably applies to 9 and 10.
> > 
> > On 11.0-CURRENT powerpc r266314M:
> > 
> > $ man ofw_console
> > No manual entry for ofw_console
> > 
> > I don't think you can call it ofw_console(4) just yet. ;-)
> 
> It's a driver in the kernel and those are section 4. :)

Well yeah, but to make it first-class citizen it's supposed to have a
manpage.

> >> Please test with INVARIANTS enabled.
> > 
> > What are the exact test steps that would be useful for you?
> 
> Just making sure it works?  I'm not sure how you force it as the console
> device or if it's just a matter of enabling it in /etc/ttys and then
> making sure you can interact with it ok as a console.

It works (w/INVARIANTS), I can interact with it ok on a console.  Meanwhile,
anyone has any idea of the following LOR?  Observed while doing some massive
copying with rsync(1) (attached).

./danfe
-------------- next part --------------
lock order reversal:
 1st 0xde59bbb8 bufwait (bufwait) @ /usr/src/sys/ufs/ffs/ffs_vnops.c:262
 2nd 0x213ee1c snaplk (snaplk) @ /usr/src/sys/ufs/ffs/ffs_snapshot.c:2297
KDB: stack backtrace:
0xd1594460: at kdb_backtrace+0x4c
0xd15944d0: at _witness_debugger+0x3c
0xd15944f0: at witness_checkorder+0xa14
0xd1594560: at __lockmgr_args+0x978
0xd15945f0: at ffs_copyonwrite+0x2fc
0xd1594680: at ffs_geom_strategy+0x138
0xd15946b0: at ufs_strategy+0xec
0xd15946e0: at VOP_STRATEGY_APV+0x138
0xd1594700: at bufstrategy+0x7c
0xd1594730: at bufwrite+0x1fc
0xd1594760: at ffs_syncvnode+0x430
0xd15947c0: at ffs_fsync+0x50
0xd15947f0: at VOP_FSYNC_APV+0x130
0xd1594810: at ufs_remove+0x100
0xd1594850: at VOP_REMOVE_APV+0x130
0xd1594870: at kern_unlinkat+0x210
0xd15949e0: at kern_unlink+0x28
0xd1594a00: at sys_unlink+0x1c
0xd1594a20: at trap+0x3c4
0xd1594b50: at powerpc_interrupt+0x18c
0xd1594b80: user SC trap by 0x4199d708: srr1=0xf032
            r1=0xffffd4f0 cr=0x40044044 xer=0 ctr=0x4199d700
lock order reversal:
 1st 0x213ee1c snaplk (snaplk) @ /usr/src/sys/kern/vfs_vnops.c:373
 2nd 0x2c49034 ufs (ufs) @ /usr/src/sys/ufs/ffs/ffs_snapshot.c:1628
KDB: stack backtrace:
0xd1594360: at kdb_backtrace+0x4c
0xd15943d0: at _witness_debugger+0x3c
0xd15943f0: at witness_checkorder+0xa14
0xd1594460: at __lockmgr_args+0x978
0xd15944f0: at ffs_snapremove+0x144
0xd1594560: at ffs_truncate+0x608
0xd1594740: at ufs_inactive+0x208
0xd1594780: at VOP_INACTIVE_APV+0x130
0xd15947a0: at vinactive+0xf4
0xd15947e0: at vputx+0x368
0xd1594830: at vput+0x18
0xd1594850: at vn_close+0x198
0xd15948a0: at vn_closefile+0x68
0xd1594900: at _fdrop+0x60
0xd1594920: at closef+0x288
0xd15949a0: at closefp+0xdc
0xd15949d0: at kern_close+0xfc
0xd1594a00: at sys_close+0x18
0xd1594a20: at trap+0x3c4
0xd1594b50: at powerpc_interrupt+0x18c
0xd1594b80: user SC trap by 0x419b1938: srr1=0xf032
            r1=0xffffdae0 cr=0x82044028 xer=0 ctr=0x419b1930