powerpc/117601: Comments (style) in /sys/powerpc/conf/{GENERIC, NOTES}

Bruce Cran bruce at cran.org.uk
Sun Oct 28 07:30:01 PDT 2007


>Number:         117601
>Category:       powerpc
>Synopsis:       Comments (style) in /sys/powerpc/conf/{GENERIC,NOTES}
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ppc
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 28 14:30:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Bruce Cran
>Release:        7.0-BETA1
>Organization:
>Environment:
FreeBSD muon.draftnet 7.0-BETA1 FreeBSD 7.0-BETA1 #0: Fri Oct 26 01:34:41 BST 2007     brucec at muon.draftnet:/usr/obj/usr/src/sys/INSPIRON  amd64
>Description:
GENERIC and NOTES files in /sys/<arch>/conf usually have a space after the # character in comments, while the powerpc files have a mixture of lines with and without spaces.  The attached patch adds spaces to those lines which don't have them.
>How-To-Repeat:
Read /sys/powerpc/conf/{GENERIC,NOTES}
>Fix:


Patch attached with submission follows:

--- /sys/powerpc/conf/GENERIC	2007-10-11 22:01:49.000000000 +0100
+++ GENERIC	2007-10-28 14:15:13.000000000 +0000
@@ -24,41 +24,41 @@
 #To statically compile in device wiring instead of /boot/device.hints
 #hints		"GENERIC.hints"
 
-makeoptions	DEBUG=-g		#Build kernel with gdb(1) debug symbols
+makeoptions	DEBUG=-g		# Build kernel with gdb(1) debug symbols
 
 # Platform support
-options 	POWERMAC		#NewWorld Apple PowerMacs
-options 	PSIM			#GDB PSIM ppc simulator
+options 	POWERMAC		# NewWorld Apple PowerMacs
+options 	PSIM			# GDB PSIM ppc simulator
 
-options 	SCHED_4BSD		#4BSD scheduler
-options 	INET			#InterNETworking
-options 	INET6			#IPv6 communications protocols
-options 	SCTP			#Stream Control Transmission Protocol
-options 	FFS			#Berkeley Fast Filesystem
-options 	SOFTUPDATES		#Enable FFS soft updates support
-options 	UFS_ACL			#Support for access control lists
-options 	UFS_DIRHASH		#Improve performance on big directories
-options 	UFS_GJOURNAL		#Enable gjournal-based UFS journaling
-options 	MD_ROOT			#MD is a potential root device
-options 	NFSCLIENT		#Network Filesystem Client
-options 	NFSSERVER		#Network Filesystem Server
-options 	NFS_ROOT		#NFS usable as root device
-options 	MSDOSFS			#MSDOS Filesystem
-options 	CD9660			#ISO 9660 Filesystem
-options 	PROCFS			#Process filesystem (requires PSEUDOFS)
-options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	GEOM_PART_GPT		#GUID Partition Tables.
-options 	GEOM_LABEL		#Provides labelization
-options 	COMPAT_43TTY		#BSD 4.3 TTY compat [KEEP THIS!]
-options 	COMPAT_FREEBSD4		#Keep this for a while
-options 	COMPAT_FREEBSD5		#Compatible with FreeBSD5
-options 	COMPAT_FREEBSD6		#Compatible with FreeBSD6
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI 
-options 	KTRACE			#ktrace(1) syscall trace support
-options 	SYSVSHM			#SYSV-style shared memory
-options 	SYSVMSG			#SYSV-style message queues
-options 	SYSVSEM			#SYSV-style semaphores
-options 	_KPOSIX_PRIORITY_SCHEDULING #Posix P1003_1B real-time extensions
+options 	SCHED_4BSD		# 4BSD scheduler
+options 	INET			# InterNETworking
+options 	INET6			# IPv6 communications protocols
+options 	SCTP			# Stream Control Transmission Protocol
+options 	FFS			# Berkeley Fast Filesystem
+options 	SOFTUPDATES		# Enable FFS soft updates support
+options 	UFS_ACL			# Support for access control lists
+options 	UFS_DIRHASH		# Improve performance on big directories
+options 	UFS_GJOURNAL		# Enable gjournal-based UFS journaling
+options 	MD_ROOT			# MD is a potential root device
+options 	NFSCLIENT		# Network Filesystem Client
+options 	NFSSERVER		# Network Filesystem Server
+options 	NFS_ROOT		# NFS usable as root device
+options 	MSDOSFS			# MSDOS Filesystem
+options 	CD9660			# ISO 9660 Filesystem
+options 	PROCFS			# Process filesystem (requires PSEUDOFS)
+options 	PSEUDOFS		# Pseudo-filesystem framework
+options 	GEOM_PART_GPT		# GUID Partition Tables.
+options 	GEOM_LABEL		# Provides labelization
+options 	COMPAT_43TTY		# BSD 4.3 TTY compat [KEEP THIS!]
+options 	COMPAT_FREEBSD4		# Keep this for a while
+options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
+options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
+options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI 
+options 	KTRACE			# ktrace(1) syscall trace support
+options 	SYSVSHM			# SYSV-style shared memory
+options 	SYSVMSG			# SYSV-style message queues
+options 	SYSVSEM			# SYSV-style semaphores
+options 	_KPOSIX_PRIORITY_SCHEDULING # Posix P1003_1B real-time extensions
 options 	AUDIT			# Security event auditing
 
 # To make an SMP kernel, the next line is needed
@@ -115,7 +115,7 @@
 # The `bpf' device enables the Berkeley Packet Filter.
 # Be aware of the administrative consequences of enabling this!
 # Note that 'bpf' is required for DHCP.
-device		bpf		#Berkeley packet filter
+device		bpf		# Berkeley packet filter
 
 # USB support
 device		uhci		# UHCI PCI->USB interface
--- /sys/powerpc/conf/NOTES	2007-09-28 22:51:10.000000000 +0100
+++ NOTES	2007-10-28 14:13:08.000000000 +0000
@@ -12,8 +12,8 @@
 # You must specify at least one CPU (the one you intend to run on).
 cpu		OEA
 
-options 	POWERMAC		#NewWorld Apple PowerMacs
-options 	PSIM			#GDB PSIM ppc simulator
+options 	POWERMAC		# NewWorld Apple PowerMacs
+options 	PSIM			# GDB PSIM ppc simulator
 
 options		SC_OFWFB		# OFW frame buffer
 


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ppc mailing list