net-mgmt/icingaweb2 fails to build with PHP 7.3

[Stefan Bethke]

It appears that (older?) versions of icingaweb2 do not work correctly with PHP 7.3. From my poudriere build log:
> ===>  Staging for icingaweb2-2.6.2_1
> ===>   Generating temporary packing list
> /bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/share/examples/icingaweb2/bash_completion.d/
> install  -m 0644 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/icingaweb2-2.6.2/etc/bash_completion.d/icingacli  /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/share/examples/icingaweb2/bash_completion.d
> (cd /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/icingaweb2-2.6.2 && /bin/rm -f -r .mailmap changelog.py icingaweb2.spec  bin/license_writer.py packages test)
> (/usr/bin/find /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/icingaweb2-2.6.2 -name "*.bak" -delete)
> /bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2
> (cd /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/icingaweb2-2.6.2 &&  /bin/sh -c '(/usr/bin/find -Ed $1 $3 | /usr/bin/cpio -dumpl $2 >/dev/null 2>&1) &&  /usr/bin/find -Ed $1 $3 \(   -type d -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 755 "$@"'\'' . {} +  -o -type f -exec /bin/sh -c '\''cd '\''$2'\'' && chmod 0644 "$@"'\'' . {} + \)' COPYTREE_SHARE . /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2)
> /bin/chmod 755 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/bin/icingacli
> install -l rs /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/bin/icingacli /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/bin/icingacli
> /bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/etc/icingaweb2
> /bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/share/examples/icingaweb2/apache
> (cd /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2 &&  ICINGAWEB_CONFIGDIR=/nonexistent  ./bin/icingacli setup config webserver apache --path=/icingaweb2  --root=/usr/local/www/icingaweb2/public --config=/usr/local/etc/icingaweb2  --file=/wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/share/examples/icingaweb2/apache/icingaweb2.conf)
> 
> Fatal error: Uncaught ErrorException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/Modules/Module.php:689
> Stack trace:
> #0 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/ClassLoader.php(303): Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, '"continue" targ...', '/wrkdirs/usr/po...', 689, Array)
> #1 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/ClassLoader.php(303): require()
> #2 [internal function]: Icinga\Application\ClassLoader->loadClass('Icinga\\Applicat...')
> #3 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/Modules/Manager.php(227): spl_autoload_call('Icinga\\Applicat...')
> #4 /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/Application in /wrkdirs/usr/ports/net-mgmt/icingaweb2/work/stage/usr/local/www/icingaweb2/library/Icinga/Application/Modules/Module.php on line 689
> *** Error code 255
> 
> Stop.
> make: stopped in /usr/ports/net-mgmt/icingaweb2

I’ve also found this Debian issue:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914457

Are you working on a fix? Otherwise, I might give porting the Debian change as a local patch.


Stefan

-- 
Stefan Bethke <stb at lassitu.de>   Fon +49 151 14070811