Practice of "Sponsored by" in commit messages

[John W. O'Brien]

On 5/18/18 14:20, Kurt Jaeger wrote:
> Hi!
> 
>>>>>> The FreeBSD project could help by asking committers to qualify
>>>>>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored,
>>>>>> in way that is equivalent to the way that the actual work itself is
>>>>>> customarily attributed.
> 
>>>>> This sounds reasonable, so I suggest that you submit a
>>>>> patch to the ports handbook that describes it for maintainers
>>>>> and committers.
> 
>>>> One thing to note: FreeBSD has a custom patch to subversion to detect
>>>> "ORGANIZATION_NAME" and automatically append it to the default
>>>> template. This is likely why its getting added in unexpected places.
> 
>>> How do you think I should handle that in my forthcoming doc patch? Is
>>> there a related bug I should file against services?
> 
>> Its a client side patch of the subversion binary.  I'm not sure the
>> best way to handle it beyond perhaps changing the template a bit?
> 
> What change would be needed ? There's already a Sponsored by field ?
> 
> The custom patch is here:
> 
> https://svnweb.freebsd.org/ports/head/devel/subversion/files/extra-patch-fbsd-template?revision=411397&view=markup

I agree that this won't necessarily need to change. If anything, a very
small reminder to committers, or suggestive wording change, to fix-up
the the sponsorship line when applicable. I will submit a separate bug
with a candidate change that depends on the doc bug. I won't mind if the
doc bug is accepted and the subversion portbug is closed WONTFIX upon
review.

-- 
John W. O'Brien
OpenPGP keys:
    0x33C4D64B895DBF3B

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20180518/6c211ff1/attachment.sig>