graphics/ufraw fails to compile on 11-stable

[tech-lists]

Hello,

graphics/ufraw fails to compile.

context: freebsd-11-stable r333924, fresh ports tree as of today (r473125).

*No* ports installed. pkg delete -af was run beforehand.

root at testvm:/usr/ports/graphics/ufraw # make -DBATCH install

[...]

cc -DHAVE_CONFIG_H -I.  -I/usr/local/include  -I/usr/local/include 
-I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include 
-I/usr/local/include/cairo -I/usr/local/include/pixman-1 
-I/usr/local/include/freetype2 -I/usr/local/include/libdrm 
-I/usr/local/include/libpng16 -I/usr/local/include/harfbuzz 
-I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/atk-1.0 
-D_THREAD_SAFE -pthread  -I/usr/local/include/glib-2.0 
-I/usr/local/lib/glib-2.0/include -I/usr/local/include -pthread 
-I/usr/local/include  -I/usr/local/include -I/usr/local/include/lensfun 
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include 
-I/usr/local/include  -I/usr/local/include/libpng16   -DDCRAW_NOMAIN 
-DUFRAW_LOCALEDIR=\"/usr/local/share/locale\" -I/usr/local/include  -O2 
-pipe -march=haswell  -fstack-protector -fno-strict-aliasing  -MT 
dcraw_indi.o -MD -MP -MF .deps/dcraw_indi.Tpo -c -o dcraw_indi.o 
dcraw_indi.c
dcraw.cc:8952:30: warning: use of logical '&&' with constant operand 
[-Wconstant-logical-operand]
       is_raw += (i = get4()) && 1;
                              ^  ~
dcraw.cc:8952:30: note: use '&' for a bitwise operation
       is_raw += (i = get4()) && 1;
                              ^~
                              &
dcraw.cc:8952:30: note: remove constant to silence this warning
       is_raw += (i = get4()) && 1;
                             ~^~~~
dcraw.cc:10198:30: error: invalid suffix on literal; C++11 requires a 
space between literal and identifier [-Wreserved-user-defined-literal]
   strcpy (th->soft, "dcraw v"DCRAW_VERSION);
                              ^

dcraw.cc:10723:44: warning: adding 'unsigned int' to a string does not 
append to the string [-Wstring-plus-int]
       write_ext = ".pgm\0.ppm\0.ppm\0.pam" + colors*5-5;
                   ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
dcraw.cc:10723:44: note: use array indexing to silence this warning
       write_ext = ".pgm\0.ppm\0.ppm\0.pam" + colors*5-5;
                                            ^
                   &                        [         ]
16 warnings and 1 error generated.
gmake[4]: *** [Makefile:919: dcraw.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
mv -f .deps/ufraw_settings.Tpo .deps/ufraw_settings.Po
mv -f .deps/dcraw_api.Tpo .deps/dcraw_api.Po
mv -f .deps/ufraw_lensfun.Tpo .deps/ufraw_lensfun.Po
mv -f .deps/ufobject.Tpo .deps/ufobject.Po
mv -f .deps/dcraw_indi.Tpo .deps/dcraw_indi.Po
gmake[4]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
gmake[3]: *** [Makefile:1059: all-recursive] Error 1
gmake[3]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
gmake[2]: *** [Makefile:609: all] Error 2
gmake[2]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/ufraw
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/ufraw

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

root at testvm:/usr/ports/graphics/ufraw# make MAKE_JOBS_UNSAFE=yes

[...]

dcraw.cc:1126:19: warning: implicit conversion from 'int' to 'short' 
changes value from 65535 to -1 [-Wconstant-conversion]
     FORC3 rp[c] = CLIP(pix[c] * sraw_mul[c] >> 10);
                 ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dcraw.cc:241:32: note: expanded from macro 'CLIP'
#define CLIP(x) LIM((int)(x),0,65535)
                                ^~~~~
dcraw.cc:239:38: note: expanded from macro 'LIM'
#define LIM(x,min,max) MAX(min,MIN(x,max))
                                      ^~~
/usr/local/include/glib-2.0/glib/gmacros.h:291:42: note: expanded from 
macro 'MIN'
#define MIN(a, b)  (((a) < (b)) ? (a) : (b))
                                          ^
/usr/local/include/glib-2.0/glib/gmacros.h:288:42: note: expanded from 
macro 'MAX'
#define MAX(a, b)  (((a) > (b)) ? (a) : (b))
                                          ^
dcraw.cc:8952:30: warning: use of logical '&&' with constant operand 
[-Wconstant-logical-operand]
       is_raw += (i = get4()) && 1;
                              ^  ~
dcraw.cc:8952:30: note: use '&' for a bitwise operation
       is_raw += (i = get4()) && 1;
                              ^~
                              &
dcraw.cc:8952:30: note: remove constant to silence this warning
       is_raw += (i = get4()) && 1;
                             ~^~~~
dcraw.cc:10198:30: error: invalid suffix on literal; C++11 requires a 
space between literal and identifier [-Wreserved-user-defined-literal]
   strcpy (th->soft, "dcraw v"DCRAW_VERSION);
                              ^

dcraw.cc:10723:44: warning: adding 'unsigned int' to a string does not 
append to the string [-Wstring-plus-int]
       write_ext = ".pgm\0.ppm\0.ppm\0.pam" + colors*5-5;
                   ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
dcraw.cc:10723:44: note: use array indexing to silence this warning
       write_ext = ".pgm\0.ppm\0.ppm\0.pam" + colors*5-5;
                                            ^
                   &                        [         ]
16 warnings and 1 error generated.
gmake[4]: *** [Makefile:919: dcraw.o] Error 1
gmake[4]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
gmake[3]: *** [Makefile:1059: all-recursive] Error 1
gmake[3]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
gmake[2]: *** [Makefile:609: all] Error 2
gmake[2]: Leaving directory '/usr/ports/graphics/ufraw/work/ufraw-6d3259a'
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/ufraw
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/ufraw
root at testvm:/usr/ports/graphics/ufraw#

thanks,

-- 
J.