Regression affecting some database daemons on 12-CURRENT

[Mateusz Piotrowski]

Hello,

Due to the changes in rc.subr introduced by r328331[1] some of the
database services are broken on FreeBSD 12-CURRENT.

Before r328331 some database services defined a bool variable
`${name}_limits`. When it was set to YES it triggered limits(1) to run
before a daemon was started.

Revision 328331 introduced a standard mechanism to do it. As a result
daemon maintainers/developers no longer have to roll out their own
solutions. The problem is that the semantics of the new common
mechanism is not compatible with many service files. `${name}_limits`
used to be a bool variable whereas now it is a string of extra flags to
be passed to limits(1).

The following command reveals a list of potenially affected ports:

    $ cd /usr/ports
    $ find . -mindepth 4 -maxdepth 4 -type f ! -name '*patch*' \
    -exec grep -l _limits {} \+ | \
    awk -v FS=/ -v OFS=/ '{print $2,$3}' - | sort | uniq

    databases/arangodb32
    databases/arangodb33
    databases/clickhouse
    databases/mariadb100-server
    databases/mariadb101-server
    databases/mariadb102-server
    databases/mariadb55-server
    databases/mongodb
    databases/mongodb32
    databases/mongodb34
    databases/mongodb34-rocks
    databases/mongodb36
    databases/mysql55-server
    databases/mysql56-server
    databases/mysql57-server
    databases/mysql80-server
    databases/mysqlwsrep56-server
    databases/mysqlwsrep57-server
    databases/percona55-server
    databases/percona56-server
    databases/percona57-server

I confirm that the problem exists in all those ports.

The ports maintainers received a BCC of this message.

Initially, I thought that this bug is related only to the
databases/mongodb36 port but it turned out that it is a bigger issue.
The issue on Bugzilla for monogodb36 is here[2].

FWIW, I've submitted an update to the rc.subr manual to improve the
documentation of that new ${name}_limits variable.[3]

Regards,
Mateusz Piotrowski

[1]: https://svnweb.freebsd.org/base?view=revision&revision=r328331
[2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226907
[3]: https://reviews.freebsd.org/D14928