diff and submissions

[Aristedes Maniatis]

On 5/5/17 8:17pm, Mathieu Arnold wrote:
> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
>>> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat at FreeBSD.org> wrote:
>>>
>>> If you went as far as being able to create a pull request, you can do a
>>> git show HEAD or git diff origin/trunk...HEAD and submit that in the
>>> FreeBSD PR as well.
>> It's pretty easy to extract the diff from a PR on GitHub, just append
>> ".diff", and ".patch" works too, but gives the full git commit history:
>>
>> https://github.com/freebsd/freebsd-ports/pull/62.diff
> 
> Yes, I am aware of that, the problem with github pull requests is that
> they are outside of the FreeBSD bug report process, they do not get
> assigned to maintainers, nobody notices them, they just stay there, and
> get obsolete.
> There have been 61 before, yes, I closed a lot because they were
> obsolete because it is outside of our process and nobody noticed them,
> and for the rest either asked the submitter to open a PR on our
> bugzilla, or opened one myself.
> 

A simple short term workaround might be:

1. Create a pull request template in github [1]

2. Include in it links to bugzilla and instructions for people to create a parallel bug report with a link back to github


The main reason I like github is that it is trivial to fork the repository, copy in my patched port files and add comments to the commit. It is considerably more different to remember to create .orig files and then diff them all, bundle it into a shar format and attach to bugzilla.

This is all from the perspective of someone who makes a submission once every 3-6 months. Obviously if I had svn commit rights or had even checked out the ports tree from svn then I'd have other options. Most people like me use portsnap so they don't have an svn checkout.


Cheers
Ari





[1] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/



-- 
-------------------------->
Aristedes Maniatis
CEO, ish
https://www.ish.com.au
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20170505/e95e6fab/attachment.sig>