svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt

[Mathieu Arnold]

Le 21/03/2017 à 08:27, Gleb Smirnoff a écrit :
> On Tue, Mar 21, 2017 at 08:22:19AM +0100, Baptiste Daroussin wrote:
> B> On Mon, Mar 20, 2017 at 11:54:33PM -0700, Gleb Smirnoff wrote:
> B> > On Tue, Mar 21, 2017 at 07:50:32AM +0100, Antoine Brodin wrote:
> B> > A> >   This change is known to break a ton of ports. More than 100 if
> B> > A> > counting depends. I'm sorry for that and I already started to fix
> B> > A> > them.
> B> > A> >
> B> > A> > Please send all new breakages to me.
> B> > A> 
> B> > A> Hi,
> B> > A> 
> B> > A> Exp-runs should happen before breakage happens, not after.
> B> > A> If you already know that it breaks hundreds of ports, please revert
> B> > A> and request an exp-run.
> B> > 
> B> > The exp-run has already been made:
> B> > 
> B> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210673
> B> > 
> B> > Wasn't very helpful.
> B> > 
> B> 
> B> I disagree it was useful it showed you some ports that were breaking given there
> B> was some high level one you were expected to provide patches to fix them.
>
> I'm working on them right now.

You should have worked on it *before* the patch breaking everything
landed, providing patches for the ports that were reported as broken,
and repeat until all the ports that were building before were building
again.

You should **not** have committed the patch to the src tree before all
those patches were created, and you should have committed all the
patches at once, preferably before committing the patch to the src tree.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20170321/669e6e98/attachment.sig>