svnup is b0rken!

Mon Jun 12 23:18:25 UTC 2017

Hello,

It looks like the latest version of Subversion has become more strict with
regards to CR+LFs and the attached patch should get things working for you
again.  Please give it a try and let me know how it goes.

I've got a couple other fixes I'm working on and I'm hoping to have 1.08
rolled out in the next week or so.  I used to host the tarball on my
personal web server (which due to an ISP change is no longer available) and
I'm looking into finding a new place to host it (probably github).

On Mon, Jun 12, 2017 at 1:03 PM, Maxim Sobolev <sobomax at freebsd.org> wrote:

> Hi, latest version of the svnup package is broken on several of my boxes.
> I've tried few public svn mirrors makes no difference.
>
> -Max
>
> [sobomax at van01 ~/projects/softswitch]$ svnup ports
> # Revision: 443456
>
> Command Failure: HTTP/1.1 400 Bad Request
> Date: Mon, 12 Jun 2017 18:01:09 GMT
> Server: Apache
> Connection: close
> Content-Type: text/html; charset=iso-8859-1
>
> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
> <html><head>
> <title>400 Bad Request</title>
> </head><body>
> <h1>Bad Request</h1>
> <p>Your browser sent a request that this server could not understand.<br />
> </p>
> </body></html>
>
>

-- 
John Mehr
Software Developer / Database Administrator
Humphrey School of Public Affairs, University of Minnesota
-------------- next part --------------
54c54
< #define SVNUP_VERSION "1.07"
---
> #define SVNUP_VERSION "1.07a"
1542d1541
< 	struct stat  local;
1565,1570c1564,1569
< 		"<S:update-report xmlns:S=\"svn:\">\n"
< 		"<S:src-path>/%s</S:src-path>\n"
< 		"<S:target-revision>%d</S:target-revision>\n"
< 		"<S:depth>unknown</S:depth>\n"
< 		"<S:entry rev=\"%d\" depth=\"infinity\" start-empty=\"true\"></S:entry>\n"
< 		"</S:update-report>\n"
---
> 		"<S:update-report xmlns:S=\"svn:\">"
> 		"<S:src-path>/%s</S:src-path>"
> 		"<S:target-revision>%d</S:target-revision>"
> 		"<S:depth>unknown</S:depth>"
> 		"<S:entry rev=\"%d\" depth=\"infinity\" start-empty=\"true\"></S:entry>"
> 		"</S:update-report>\r\n"
1575c1574
< 		strlen(connection->branch) + revision_length + revision_length + strlen(SVNUP_VERSION) + 206,
---
> 		strlen(connection->branch) + revision_length + revision_length + 205,
2392,2394c2391,2393
< 					"PROPFIND %s HTTP/1.1\n"
< 					"Depth: 1\n"
< 					"Host: %s\n\n",
---
> 					"PROPFIND %s HTTP/1.1\r\n"
> 					"Depth: 1\r\n"
> 					"Host: %s\r\n\r\n",
2474,2476c2473,2475
< 						"GET %s HTTP/1.1\n"
< 						"Host: %s\n"
< 						"Connection: Keep-Alive\n\n",
---
> 						"GET %s HTTP/1.1\r\n"
> 						"Host: %s\r\n"
> 						"Connection: Keep-Alive\r\n\r\n",