ports/devel/noweb/Makefile FETCH_* is wrong, comment out works.

[Mathieu Arnold]

Le 05/01/2017 à 14:34, Julian H. Stacey a écrit :
> ports/devel/noweb/Makefile contains
> 	FETCH_CMD=    /usr/bin/ftp
> 	FETCH_ARGS=   # empty
> that is wrong, because if one already has the distfile on a local site
> (accessed via MASTER_SITE_OVERRIDE or MASTER_SITE_BACKUP ), 
> it hangs & fails on make fetch.
>

This is true. But:

$ fetch -v ftp://www.eecs.harvard.edu/pub/nr/noweb-2.11b.tgz
looking up www.eecs.harvard.edu
connecting to www.eecs.harvard.edu:21
setting passive mode
opening data connection
fetch: ftp://www.eecs.harvard.edu/pub/nr/noweb-2.11b.tgz: No route to host

And:

$ ftp ftp://www.eecs.harvard.edu/pub/nr/noweb-2.11b.tgz
Connected to www-aws.eecs.harvard.edu.
220-
 Anonymous access only (no uploads).
 For authenticated access, please use SCP, SFTP, or FTP over SSH.
 Thank you, <ftpmaster at eecs.harvard.edu>.
220 FTP Server ready.
331 Anonymous login ok, send your complete email address as your password
230 Anonymous login ok, restrictions apply.
Remote system type is UNIX.
Using binary mode to transfer files.
200 Type set to I
250 CWD command successful
250 CWD command successful
local: noweb-2.11b.tgz remote: noweb-2.11b.tgz
229 Entering Extended Passive Mode (|||65306|)
150 Opening BINARY mode data connection for noweb-2.11b.tgz (738870 bytes)
100%
|******************************************************************************************************************************************************************************************************************|  
721 KiB  599.13 KiB/s    00:00 ETA226 Transfer complete
738870 bytes received in 00:01 (554.01 KiB/s)
221 Goodbye.
$

The port MUST be able to fetch from its MASTER_SITE, and I am talking
about the one in the Makefile, not what gets added/changed by the
framework. Otherwise, the backup master site, or the place where you
have a local cache cannot be filled with something in the first place.

In the future, when fetch(1) manages to fetch from that ftp site on all
our supported releases, feel free to patch the Makefile.

Regards,

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20170105/56d2aebf/attachment.sig>