svn commit: r432796 - in head/graphics: rawtherapee rawtherapee-devel

John Marino at
Fri Feb 3 21:03:46 UTC 2017

On 2/3/2017 14:55, Matthias Andree wrote:
> Am 29.01.2017 um 20:22 schrieb John Marino:
>> Author: marino
>> Date: Sun Jan 29 19:22:47 2017
>> New Revision: 432796
>> URL:
>> Log:
>>   graphics/rawtherapee(-devel): Fix OSVERSION, use with OPSYS
>>   The OSVERSION for FreeBSD 10.3 is 1003000, not 1030000.  The last commit
>>   blocked FreeBSD 10.3 too.  OSVERSION is also supposed to be used in
>>   conjunction with OPSYS.
>>   Approved by:	just-fix-it
>> Modified:
>>   head/graphics/rawtherapee-devel/Makefile
>>   head/graphics/rawtherapee/Makefile
>> Modified: head/graphics/rawtherapee-devel/Makefile
>> ==============================================================================
>> --- head/graphics/rawtherapee-devel/Makefile	Sun Jan 29 19:19:06 2017	(r432795)
>> +++ head/graphics/rawtherapee-devel/Makefile	Sun Jan 29 19:22:47 2017	(r432796)
>> @@ -76,7 +76,8 @@ OPTIMIZED_CFLAGS_CFLAGS=	-O3 -funroll-lo
>>  # -------------------------------------------------------------------
>>  #
>> -.if ${OSVERSION} < 1030000
>> +.if ${OPSYS} == FreeBSD
>> +.if ${OSVERSION} < 1003000
>>  IGNORE=	is only for supported FreeBSD releases
>>  .endif
> Good catch, John, and thanks for the fix-up.
> I have one nit to pick about the OPSYS - where is it documented that
> OPSYS is mandatory for OSVERSION?  It's not in unless I dive
> deep into the implementation, and not in the porter's handbook.
> I'm a FreeBSD ports committer and will not proactively deal with keeping
> my stuff compatible with other systems, let alone test there.
> Bottom line: I regularly omit the OPSYS checks because I have zero clue
> about the related versions on other systems, nor do I care.

You don't have to worry about other systems.  You only have to make sure 
you don't use OSVERSION without OPSYS.  Given that using OSVERSION 
should be avoided if possible (e.g. use a file existence check if 
possible), having a small requirement on the use of OSVERSION isn't that 
much to ask, is it?

AFAIK it's not documented, but it's been spoken here quite a few times 
and the result was "try to be nice and if you must use OSVERSION, guard 
it with OPSYS".  Anything else is a bug because OSVERSION only makes 
sense with an exact value of OPSYS ("FreeBSD").

So please, if you can, respect this guideline regardless if it's 
documented, and if not, at least let others make the correction.  I'd 
like to take the opportunity to thank all the FreeBSD committers that 
make the effort to guard OSVERSION.  It does not go unnoticed and I 
definitely appreciate it.


This email has been checked for viruses by Avast antivirus software.

More information about the freebsd-ports mailing list