net-mgmt/prometheus update to 1.6.0, comitter requested

[Larry Rosenman]

Indeed.  I’m working with my Mentor (adamw@, and swills@(of portmgr@)) and they had the issue with unknown.

 

I’ll get this done. ☺ 

 

 

-- 

Larry Rosenman                     http://www.lerctr.org/~ler

Phone: +1 214-642-9640                 E-Mail: ler at lerctr.org

US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281

 

 

 

From: Jev Björsell <jev at ecadlabs.com>
Date: Thursday, April 20, 2017 at 1:39 PM
To: Larry Rosenman <ler at lerctr.org>, "freebsd-ports at freebsd.org" <freebsd-ports at freebsd.org>
Subject: Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested

 

Hi Larry,

 

I presume you are referring the the strings 'unknown' that appear in the  do-build: portion of the Makefile.

 

These are set to 'unknown' on purpose, because we do not have a way of finding out that information unless we do it dynamically at build time. Doing dynamically is not recommended for several reasons.

 

This data gets displayed when a user runs `prometheus -version`, and most of the fields are only really relevant to dev builds anyway.

 

The crucial information is the software version number which is set.

 

You can see me exchange on the subject in the ports mailing list archive here:

 

https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html

 

-Jev

 

 

On Wed, Apr 19, 2017 at 9:23 PM ler <ler at lerctr.org> wrote:

Can you fill in the unknown stuff in the version package or should I just go ahead and do it?



On Apr 19, 2017 at 10:22 PM, <Jev Björsell> wrote: 

Thanks Larry,

 

I have updated the patch on the bug, because the upstream project has just released a minor version/bug fix release. New patch updates us to 1.6.1.

 

Thanks,

-Jev

 

On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman <ler at lerctr.org> wrote:

On 4/18/17, 2:41 PM, "Jev Björsell" <owner-freebsd-ports at freebsd.org on behalf of jev at ecadlabs.com> wrote:

    Hi All,

    Could I get a committer to apply my latest update patch for net-mg
    mt/prometheus?

    Patch is available here:
    https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218737

    Thanks so much,
    -Jev

Waiting for my mentor to approve.