mysql57 now fails to build on FreeBSD 9 with libressl

[Mathieu Arnold]

Le 28/09/2016 à 17:51, mokhi a écrit :
> Hi.
> Your change now makes building on all 9.x broken.

Yes, you have to tell the ports framework to use OpenSSL from ports to
be able to build it.

> Actually the problem is mysql57's needed minimum version of openssl is
> newer than what we have as openssl-base on 9.x
> So to support building and running it on all freebsd versions we need
> two branches of rules in Makefile.
> For 9.x we should install openssl from ports.
> For newer (>= 10) nothing is needed to be changed and openssl-base in
> enough (and port can be chosen by user from configs).
>
> The problem goes more complex to deal with when it comes to support
> libressl too.
>
> I understand why you say it's stupid to change defaults in the
> Makefile, but I just added `WITH_OPENSSL_PORT=yes` to Makefile and
> poudriere suggested me to change it to `DEFAULT_VERSIONS+=ssl=openssl`

No, poudriere told you:

Using WITH_OPENSSL_PORT in make.conf is deprecated, replace it with
DEFAULT_VERSIONS+=ssl=openssl in your make.conf

There is something very important in that sentence you missed, it is the
"*in your make.conf" part.

> BTW, if you think there's no better way to fix building it on 9.x, we
> can mark port as ignore/broken on 9.x (and notify users that they can
> add such statement to their make.conf) till we find a better way.

Feel free to use WITH_OPENSSL_PORT in the Makefile, it too, is a global
knob, but its use in the ports Makefile is so common that it is acceptable.

There is a good chance this knob too is going away, and the packages for
mysql 5.7 will not build on 9.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20160928/b7a2d579/attachment.sig>