iozone3-434 fails to rebuild

[Don Lewis]

On 21 Jun, Jim Ohlstein wrote:
> Hello,
> 
>> On Jun 21, 2016, at 4:14 PM, Alphons van Werven <freebsd at skysmurf.nl>
>> wrote:
>> 
>> Doug Sampson wrote:
>> 
>>> it crashes as follows:
>>> 
>>>  ###
>>> <...snip...>
>>> iozone.c:1297:1: error: unknown type name 'off64_t'; did you mean
>>> 'off_t'? off64_t offset = 0;               /*offset for random I/O
>>> */
>>> ^~~~~~~
>>> off_t
>>> /usr/include/sys/types.h:173:18: note: 'off_t' declared here
>>> typedef __off_t         off_t;          /* file offset */
>>>                        ^
>> [snip]
>>> Doesn't matter which config options I select/deselect,
>> 
>> As far as I can tell it doesn't *crash*, it merely fails to build ;-)
>> 
>> I don't think the options are relevant in this case. If I'm not
>> mistaken off64_t is some kind of GNU extension, but installing
>> lang/gcc and trying to compile a piece of sample code with GCC still
>> didn't work for me. Which means I can reproduce the problem on
>> 10.2-RELEASE-p19/amd64.
>> 
>> There seems to be a #define or typedef missing somewhere. Perhaps
>> somebody can ask around upstream what the authors are expecting from
>> the off64_t type, so we can find a suitable replacement on FreeBSD
>> systems: probably offset_t, (u)int64_t, or something along those
>> lines.
> 
> How about it be reverted to the previous, WORKING, version in the
> meantime, and before an "upgrade" is committed, proper testing is
> done?

The previous version didn't build on recent FreeBSD 11, which does
define off64_t.  I started trying to fix it, but the code is really
nasty and I finally gave up.