The ports collection has some serious issues

[John Marino]

Grzegorz Junka wrote:
> On 17/12/2016 18:51, John Marino wrote:
>> On 12/17/2016 12:34, abi wrote:
>>>
>>>>> 2. It doesn't provide dialog for port options, so
>>>>> 2.1 I don't receive information if port options have changed. I don't
>>>>> know what else will be pulled to my system after port tree update.
>>>>
>>>> which of course is a false statement.
>>>> If you set port options which then change, Synth will stop and tell
>>>> you to reconfigure or remove the saved port options.
>>>
>>> Not at all. For example, let's assume I go recommended way and have
>>> options for ports with not default settings. Let's say, I have perl with
>>> default options (no OPTIONS file). Let's say port maintainer adds new
>>> option, [NSA Backdoor]
>>> Perl will be silently compiled with that option, right?
>>
>> Yes.  If you don't explicitly save the options then Synth has no way
>> to detect a change in options.
>
> Isn't poudriere automatically saving the options file when building a
> new port with default options (i.e. when no options have been
> specified)? And also, aren't the selected options available in the
> resulted pkg file, so that synth could look them up there?
> Grzegorz

[please keep me CC'd, I can't respond easily if not]

Synth does look up package options.  It compares it with the currently 
options specifications and will obsolete the package if they don't match 
exactly.

Synth intentionally does not store option files.  It will use option 
files that are pre-created for it (the lack of stored options means "use 
the defaults").

The behavior is intentional and it results in synth rarely having to 
break a scan and stop and most people want this, but it just so happens 
that abi wanted the exact opposite behavior.  It's actually the first 
time I've heard somebody wanting the "explicitly save options" behavior 
because it's quite disruptive in practice. [1]

John

[1] I wonder how hard it would be for Synth to optionally create an 
saved options file (outside of the ports framework) when the package is 
successfully built.  It's likely possible (non-default behavior)

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus