Committer needed for PR 208029

Martin Waschbüsch martin at waschbuesch.de
Tue Apr 5 21:37:28 UTC 2016


> Umm probably a really bad idea...  consider this or something more creative/descriptive:
> 
> .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 && ${WITH_OPENSSL_PORT} != "yes"
> BROKEN=		You must set WITH_OPENSSL_PORT=yes in /etc/make.conf on Pre 10.x
> .endif
> 
> 
> ... the idea instead of silently turning it on which could cause a myriad of hell for production systems where some ports are compiled against security/openssl and some against the base openssl... stop the compile and tell the user what they have to do to resolve it... which will then make anything else use the same openssl and lessen the dependency/library issues that could happen.

Actually, I just noticed (when compiling the port), that the Makefile now says:

WITH_OPENSSL_PORT=yes

GNUTLS_CONFIGURE_WITH=  gnutls
GNUTLS_LIB_DEPENDS=     libgnutls.so:security/gnutls

POLARSSL_CONFIGURE_WITH=mbedtls
POLARSSL_LIB_DEPENDS=   libmbedtls.so:security/polarssl13

.include <bsd.port.options.mk>

.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000
WITH_OPENSSL_PORT=yes
.endif

Which means that the ports version is used regardless of OSVERSION...

Shall I open a PR for it and incorporate the BROKEN= approach?

Martin


More information about the freebsd-ports mailing list