MASTER_SITE_SUBDIR

[Mathieu Arnold]

Hi,

TL;DR: As in, don't use it, you're going to hurt yourselves, I'm not
kidding.



In ancient times, you had to do horribly complicated stuffs like:

MASTER_SITES=  ${MASTER_SITE_LOCAL:S/$/:local/}
${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
MASTER_SITE_SUBDIR=    mat/:local DBIx/:cpan
DISTFILES=     ${DISTNAME}${EXTRACT_SUFX}:local,cpan


For the past 9 years, to be precise r169110, modulo a few bugs corrections,
you have been able to do:

MASTER_SITES=  LOCAL/mat CPAN/DBIx

Please, do, now.



As to why, here are a few examples that, while looking inconspicuously
good, were *not* working as expected, and their new, working, version:

------------------
MASTER_SITES=  ${MASTER_SITE_SAVANNAH}:m17n \
               ${MASTER_SITE_GNU:S/$/:glibc/}
MASTER_SITE_SUBDIR=    m17n/:m17n \
               glibc/:glibc
------------------ ->
MASTER_SITES=  SAVANNAH/m17n:m17n GNU/glibc:glibc
------------------


------------------
MASTER_SITES=  ${MASTER_SITE_LOCAL:S|%SUBDIR%|kiri/wmicons|} \
               ${MASTER_SITE_WINDOWMAKER} \
               ${MASTER_SITE_PORTS_JP} \
MASTER_SITE_SUBDIR=    . contrib/old/icons
------------------ ->
MASTER_SITES=  LOCAL/kiri/wmicons \
               WINDOWMAKER/contrib/old/icons \
               PORTS_JP \
------------------


------------------
MASTER_SITES=  ${MASTER_SITE_XCONTRIB} \
               ${MASTER_SITE_LOCAL}
MASTER_SITE_SUBDIR=    cy
MASTER_SITE_SUBDIR=    window_managers
------------------ ->
MASTER_SITE_SUBDIR= XCONTRIB/window_managers \
                    LOCAL/cy
------------------


------------------
MASTER_SITES=  ${MASTER_SITE_GNU} \
               ${MASTER_SITE_SAVANNAH}
MASTER_SITE_SUBDIR=    ${PORTNAME:S|$|:src|}
DISTFILES=     ${DISTNAME}${EXTRACT_SUFX}:src
------------------ ->
MASTER_SITES=  GNU SAVANNAH
DISTFILES=     ${DISTNAME}${EXTRACT_SUFX}
------------------


------------------
MASTER_SITES=          http://pks.sourceforge.net/:sf
${MASTER_SITE_LOCAL}:local
MASTER_SITE_SUBDIR=    .:sf mandree:local
DISTFILES=             pks-current.tgz:sf,local
------------------ ->
MASTER_SITES=          http://pks.sourceforge.net/ LOCAL/mandree
DISTFILES=             pks-current.tgz
------------------


-- 
Mathieu Arnold