review of new tcpcrypt port...
jmg at funkthat.com
Thu Nov 13 01:11:58 UTC 2014
Bryan Drewery wrote this message on Wed, Nov 12, 2014 at 18:36 -0600:
> On 11/12/2014 6:16 PM, John-Mark Gurney wrote:
> > John-Mark Gurney wrote this message on Sat, Nov 08, 2014 at 02:07 -0800:
> >> I'd like someone to review the attached port for me to commit... It
> >> contains a daemon to run on divert sockets to implement the tcpcrypt
> >> protocol. I have tested this port w/ HEAD and it works fine w/ the
> >> attached patch...
> >> The included patch has been submitted upstream and committed, but a
> >> new release has not yet been released.
> >> portlint -A looks fine.
> > As I haven't received a review, in a couple more days, probably Friday,
> > I'll commit the port...
> > Thanks.
> Can you include the security/Makefile bit in the patch too please?
Hmm... Thought I did, but I clearly did not... Fixed... I've attached
the latest version of the port..
> Have you ran it through poudriere? At the very least 'env DEVELOPER=1
> make stage' and 'make check-plist' are required. Portlint is not
> sufficient, nor can it even be trusted in all cases.
I didn't do poudriere, but I did all the building w/ DEVELOPER=1
set, which did fix a few things..
Looks like port test from porttools as documented at:
Is wrong.. you need to be in the port directory for it to work...
> If you check those and get back to me I'll approve it.
> Usually you'd need a port commit bit to commit anything, or an approval
> (which is different than a review). I hate our process, but that's how
> it is. Poke people in #bsdports on EFNet, or me on IRC, for
> approvals/reviews in the future.
Well, I'm fine w/ someone else committing the port, just trying to save
someone the work, and trying to get it into the tree in a timely
manner.. I viewed the review as approval... Guess I should have made
it more clear in my original request...
btw, the included patch has been upstreamed, but they haven't tagged a
new rc yet...
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5040 bytes
Desc: not available
More information about the freebsd-ports