[patch] sysutils/beadm

[vermaden]

Tagged as 1.1, You may create a port from that.

Regards,
vermaden

Od: "vermaden" <vermaden at interia.pl>
Do: "Andrew Hotlab" <andrew.hotlab at hotmail.com>; 
Wysłane: 7:13 Środa 2014-03-12
Temat: RE: [patch] sysutils/beadm

> Hi.
> 
> Merged, along with check if zpool.cache file exists:
> https://github.com/vermaden/beadm/commit/748d2f2b189581e1cef209f84accd250e35e0954
> 
> Regards,
> vermaden
> 
> Od: "Andrew Hotlab" 
> Do: "Bryan Drewery" ; "vermaden at interia.pl" ; 
> Wysłane: 23:23 Poniedziałek 2014-03-10
> Temat: RE: [patch] sysutils/beadm
> 
> > > Date: Mon, 10 Mar 2014 16:11:16 -0500
> > > From: bdrewery at FreeBSD.org
> > > To: andrew.hotlab at hotmail.com; vermaden at interia.pl
> > > CC: ports at freebsd.org
> > > Subject: Re: [patch] sysutils/beadm
> > >
> > > On 2014-02-13 16:19, Andrew Hotlab wrote:
> > >>
> > >> In my setup I have the following layout (several datasets for /usr,
> > >> /var, etc.):
> > >>
> > >> At this moment the utility does not seems to be able to manage this
> > >> scheme, since it sets the mountpoint property as "legacy" for all
> > >> datasets under the root, thus preventing to automatically mount any
> > >> subdirectory at boot.
> > >> I've tested this simple solution (to let do the job to the canmount
> > >> property), and it seems to solve the problem without affecting the
> > >> behavior when all system folders are located under a single root
> > >> dataset (please see the patch below). I'd be glad if you'll include it
> > >> in the next port revision.
> > >>
> > >> I'm at your disposal for any further detail.
> > >>
> > >> Best regards.
> > >>
> > >> Andrew
> > >>
> > >>
> > >> --- ./beadm 2014-01-11 17:08:31.112384992 +0100
> > >> +++ /usr/local/sbin/beadm 2014-01-11 17:06:38.620706860 +0100
> > >> @@ -505,7 +505,7 @@
> > >> if [ ${MOUNT} -eq 0 ]
> > >> then
> > >> zfs umount ${POOL}/${BEDS}/${2}
> > >> - zfs set mountpoint=legacy ${POOL}/${BEDS}/${2}
> > >> + zfs set mountpoint=/ ${POOL}/${BEDS}/${2}
> > >
> > > I've tested this and agree with it. It should be added upstream as it
> > > makes it simpler to have these extra /mounts. Otherwise you have to
> > > explicitly set them with mountpoint=/usr, /var, instead of inheriting
> > > from the / dataset.
> > > The problems I mentioned were probably before we got the 'canmount'
> > > support in to prevent remounting over /.
> > >
> > >> fi
> > >> fi
> > >> if ! zpool set bootfs=${POOL}/${BEDS}/${2} ${POOL} 1> /dev/null 2>
> > >> /dev/null
> > >> @@ -518,6 +518,7 @@
> > >> ZFS_LIST=$( zfs list -H -o name -r ${POOL}/${BEDS} )
> > >> # disable automatic mount on all inactive boot environments
> > >> echo "${ZFS_LIST}" \
> > >> + | grep -v "^${POOL}/${BEDS}$" \
> > >
> > > Note that this change is unrelated.
> > >
> > >> | grep -v "^${POOL}/${BEDS}/${2}$" \
> > >> | grep -v "^${POOL}/${BEDS}/${2}/" \
> > >> | while read NAME
> > >
> > 
> > Great! I'm glad to be helpful. I'll look forward to see the change committed to the Ports repository.
> > 
> > Thank you so much for this wonderful tool!
> > 
> > Regards.
> > 
> > Andrew 		 	   		  
> 
> 
>