security/tripwire stage error

[Cy Schubert]

Cy Schubert writes:
> In message <alpine.BSF.2.11.1406211116000.10559 at angus.tharned.org>, Greg 
> Rivers
>  writes:
> >   This message is in MIME format.  The first part should be readable text,
> >   while the remaining parts are likely unreadable without MIME-aware tools.
> > 
> > --487545500-2130553633-1403368130=:10559
> > Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
> > 
> > Cy, thanks for your recent updates.  tripwire builds nicely with clang 
> > now, but poudriere is running into a staging error:
> > 
> > ====>> Failed ports: security/tripwire:stage
> > 
> > poudriere build log attached.
> > 
> > Now that the port is no longer interactive, is the intent to package the 
> > install.sh script so that it can be run as needed for initial database 
> > setup?
> 
> Looks like it's a poudriere issue. The install script expects to have a 
> pty. Poudriere does not run subshells in ptys. You can test this by rsh 
> localhost /bin/sh. That gives you a shell but no pty.
> 
> rts/security/tripwire/work/tripwire-2.4.2.2-src'
> STGDIR="$STAGEDIR" prefix="/usr/local" sysconfdir="/usr/local/etc/tripwire" 
> \
>         path_to_vi="/usr/bin/vi" path_to_sendmail="/usr/sbin/sendmail" \
>         ./install/install.sh
> Say 'sh install.sh', not 'sh < install.sh'
> gmake[1]: Leaving directory `/export/wrkdir/amd64/export/home/cy/freebsd/svn
> /ports/security/tripwire/work/tripwire-2.4.2.2-src'
> *** Error code 2
> 
> Stop.
> make: stopped in /export/home/cy/freebsd/svn/ports/security/tripwire
> tty
> not a tty
> 
> The test below is where the check is made. The solution will be to also 
> test if on a pty or even discard the test altogether.
> 
> 	if [ ! -t 0 ] ; then
> 	        echo "Say 'sh install.sh', not 'sh < install.sh'"
> 	        exit 1
> 	fi
> 
> Having said all this, poudriere should run jails within ptys (or have the 
> option to -- probably better idea).
> 
> I don't have time to fix this now but I'll get to it when I get back home 
> tonight. The solution is pretty simple.

Managed to fix this while on the phone checking out rims for my wife's car. 
Committed.


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org