FreeBSD port graphics/xfig: patch to fix packaging with DOCS disabled (was Re: please revert graphics/xfig r354029)

[Matthew Luckie]

Please commit.  Thanks Guido for doing the digging on this one.

On Sat, May 31, 2014 at 05:34:14PM +0200, Guido Falsi wrote:
> On 05/31/14 17:09, Steve Kargl wrote:
> > On Sat, May 31, 2014 at 05:00:34PM +0200, Guido Falsi wrote:
> >> On 05/31/14 16:35, Steve Kargl wrote:
> >>> On Sat, May 31, 2014 at 03:31:34PM +0200, Guido Falsi wrote:
> >>>> On 05/31/14 02:08, Steve Kargl wrote:
> >>>>> Can someone please revert r354029 for graphics/xfig?
> >>>>> This revision breaks the ability to install the port.
> >>>>>
> >>>>> cd /usr/ports/graphics/xfig
> >>>>> svn merge -r 354029:340725 .
> >>>>>
> >>>>
> >>>> Hi,
> >>>>
> >>>> I did commit the revision you mention. I just tested the port and it
> >>>> installs fine.
> >>>
> >>> Not on my system, which is an up-to-date freebsd-current.
> >>>
> >>
> >> After some digging I found out the port is broken when the DOCS option
> >> is disabled.
> >>
> >> I'm cooking a fix I'll get to you soon.
> >>
> >> Please always report if using custom options when reporting a problem.
> >>
> > 
> > I forgot I had the DOCS option unset as it was unset ages ago
> > and updates have always worked.  The question is "why are changes
> > to a port committed without proper testing?"  Yes, "proper
> > testing" should include testing of the effects of (un)setting
> > individual Makefile options.
> > 
> 
> I'm going to fix it. I'm attaching a patch and CCing the maintainer to
> get his approval. Can you test this patch too and report back? Thanks!
> 
> Please understand we all make mistakes from time to time.
> 
> Also remember that this is a volunteer project and such a thorough
> testing as the one you are asking for isn't always possible with the
> resources at hand.
> 
> for mjl at luckie.org.nz:
> 
> A problem has been reported in the xfig port when trying to install it
> with the DOCS option disabled.
> 
> I've created a patch which fixes the problem, can you approve it?
> 
> Thanks in advance.
> 
> -- 
> Guido Falsi <madpilot at FreeBSD.org>

> Index: Makefile
> ===================================================================
> --- Makefile	(revision 355988)
> +++ Makefile	(working copy)
> @@ -24,6 +24,7 @@
>  USE_XORG=	ice sm x11 xaw xext xi xmu xpm xt
>  USE_CSTD=	gnu89
>  CFLAGS+=	-Wno-return-type
> +INSTALL_TARGET=	install install.libs
>  
>  MAKE_ENV+=	DOCSDIR=${DOCSDIR} CHMOD=${CHMOD} TAR=${TAR}
>  MAKE_ARGS+=	INSTALLFLAGS="${COPY}" \
> @@ -38,7 +39,7 @@
>  .include <bsd.port.options.mk>
>  
>  .if ${PORT_OPTIONS:MDOCS}
> -INSTALL_TARGET=	install install.libs install.html
> +INSTALL_TARGET+=	install.html
>  .endif
>  
>  .if ! ${PORT_OPTIONS:MI18N} || ! ${PORT_OPTIONS:MDOCS}

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20140531/406ed6cf/attachment.sig>