What is the problem with ports PR reaction delays?
bapt at FreeBSD.org
Sat Jan 25 17:48:40 UTC 2014
On Fri, Jan 24, 2014 at 08:16:39PM -0800, Alfred Perlstein wrote:
> On 1/24/14, 4:47 PM, John Marino wrote:
> > On 1/25/2014 01:36, Big Lebowski wrote:
> >> I was hoping to get some discussion revealing how the work is organized
> >> around ports PR, perhaps some ideas on improving them and I hoped that
> >> people who can make decisions and changes would notice it and consider
> >> them, since as they say, the squeeky wheel gets the grease, that's all. At
> >> no point I insisted on forcing anyone to anything, and I dont think that's
> >> neither only nor a viable solution.
> >> It seems obvious that current process doesnt work very well, then I'd aim
> >> at reorganizing that process - it appears that there is no roles specified,
> >> so the responsibility is blurred, and when everyone is responsible for one
> >> thing, in practice no one is. Perhaps role assignment could be of any help?
> > I'm not trying to be a jerk, but surely I'm coming off that way.
> > Again, nobody is obligated to accept any assignment. They have to
> > volunteer to do it. The only person that The Big Lebowski can influence
> > here is himself.
> > Thus, are you volunteering for this role? It's not my call, but if you
> > really want to do clean out and triage the all PRs on an ongoing basis,
> > my guess is that would be very welcome and we'd figure out a way to set
> > that up. It would definitely help, especially for those maintainer that
> > "approve" patches but the PRs never get opened (or set to a better state
> > than "open").
> > At some point we'll have a new PR system, that fact might be having an
> > impact on current PRs as well...
> To me it would speak of tooling as opposed to anything.
> Does the ports system have a 1 or 2 click interface for merging PRs like
> for instance github?
> Could ports take PRs in the form of pull requests on github?
> Wouldn't that just turn the number of updates into a few minor clicks?
> (also wouldn't it make it easier for ports submitters)?
> (maybe there is some great ports system that I'm not aware of that makes
> this all as easy github, but I somehow doubt that.)
That would imho be a total disaster, as less and less people will really take
care of reviewing the actual patch (lots of commits are already directly from Pr
patches without applying some necessary diff for consistency, correctness, Q/A
btw we already have tons of tools available to just merge patches directly from
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 196 bytes
Desc: not available
More information about the freebsd-ports