poudriere: setting up jail failes

[Russell L. Carter]

On 08/08/14 12:27, Bryan Drewery wrote:
> On 8/8/2014 1:57 PM, Matthias Apitz wrote:
>> And, btw., why is poudriere removing all the jail when an error occures?
>> Wouldn't it be better to let it there to have a look into and remove it
>> on the next run?
> 
> Yes I agree this should probably change. I'll evaluate it after the 3.1
> release which is the major focus right now. The jail command has a lot
> of issues with building and error handling.
> 

Since I haven't heard anybody else complain I've not looked into this
further, but just in case...  I can always build ports the first time
after a boot, but the second time it fails with the below commented out
statements, even though AFAICT the previous successful run
shutdown cleanly.  This is on recent currents with nightly updated
ports (including poudriere).

(BTW poudriere on an 8-core machine running on a zfs SSD is
FANTASTIC!  This needs to be applied to the world... Thank you
very much. A big reason I went to debian 14 years ago was for
the joy of binary packages.  Now openoffice, thunderbird, who
cares.)

Anyway, haven't had a single problem with the following kludge:

rcarter at terpsichore> diff -u ports.sh.orig ports.sh
--- ports.sh.orig       2014-07-27 09:39:19.182960646 -0700
+++ ports.sh    2014-08-06 13:58:23.510929452 -0700
@@ -199,8 +199,8 @@
        porttree_exists ${PTNAME} || err 2 "No such ports tree ${PTNAME}"
        PTMNT=$(pget ${PTNAME} mnt)
        [ -d "${PTMNT}/ports" ] && PORTSMNT="${PTMNT}/ports"
-       /sbin/mount -t nullfs | /usr/bin/grep -q "${PORTSMNT:-${PTMNT}}
on" \
-               && err 1 "Ports tree \"${PTNAME}\" is currently mounted
and being used."
+#      /sbin/mount -t nullfs | /usr/bin/grep -q "${PORTSMNT:-${PTMNT}}
on" \
+#              && err 1 "Ports tree \"${PTNAME}\" is currently mounted
and being used."
        msg_n "Deleting portstree \"${PTNAME}\""
        destroyfs ${PTMNT} ports
        rm -rf ${POUDRIERED}/ports/${PTNAME} || :
@@ -212,8 +212,8 @@
        METHOD=$(pget ${PTNAME} method)
        PTMNT=$(pget ${PTNAME} mnt)
        [ -d "${PTMNT}/ports" ] && PORTSMNT="${PTMNT}/ports"
-       /sbin/mount -t nullfs | /usr/bin/grep -q "${PORTSMNT:-${PTMNT}}
on" \
-               && err 1 "Ports tree \"${PTNAME}\" is currently mounted
and being used."
+#      /sbin/mount -t nullfs | /usr/bin/grep -q "${PORTSMNT:-${PTMNT}}
on" \
+#              && err 1 "Ports tree \"${PTNAME}\" is currently mounted
and being used."
        msg "Updating portstree \"${PTNAME}\""
        if [ -z "${METHOD}" -o ${METHOD} = "-" ]; then
                METHOD=portsnap