foomatic-rip and foo2zjs

[Boris Samorodov]

25.04.2014 19:35, Stefan Bethke пишет:
> Am 25.04.2014 um 15:20 schrieb Robert Backhaus <robbak at robbak.com>:
> 
>> Anyway, here's a backtrace: - but the pointed line, 1200, just looks wrong - 
>>
>> int fd = mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built - Yup, that's it. Here's the patch:
>>
>> --- foomaticrip.c.orig  2014-04-25 23:16:06.000000000 +1000
>> +++ foomaticrip.c       2014-04-25 23:16:47.000000000 +1000
>> @@ -1197,7 +1197,7 @@
>>          debug = 1;
>>  
>>      if (debug) {
>> -       int fd = mkstemp (LOG_FILE "-XXXXXX.log");
>> +       int fd = mkstemp ("LOG_FILE-XXXXXX.log");
>>         if (fd != -1)
>>             logh = fdopen(fd, "w");
>>         else
> 
> Sorry, that patch does’t look right to me. LOG_FILE should be a define that get’s concatenated with the string literal. Since this is compile-time, I don’t see how this would lead to a runtime error, unless LOG_FILE was defined to some unusual value.

You are right, the definition is at foomaticrip.h:
-----
/* This is the location of the debug logfile (and also the copy of the
 * processed PostScript data) in case you have enabled debugging above.
 * The logfile will get the extension ".log", the PostScript data ".ps".
 */
#ifndef LOG_FILE
#define LOG_FILE "/tmp/foomatic-rip"
#endif
-----

Hm, was LOG_FILE defined earlier?

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve