Help understanding ports tinderbox failure report?
Tijl Coosemans
tijl at FreeBSD.org
Mon Sep 23 08:24:07 UTC 2013
On Mon, 23 Sep 2013 10:08:11 +0200 Pietro Cerutti wrote:
> On 2013-Sep-22, 17:55, David Wolfskill wrote:
>> Back in July, I filed PR ports/180642 (as the port maintainer for
>> astro/gpsman) to update that port from 6.4.4 to 6.4.4.1.
> [snip]
>> I've attached a revised patch, to:
>> * Perform the 6.4.4 -> 6.4.4.1 upgrade.
>> * Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+= tk:wrapper,run".
>> * Avoid showing the pkg-message if NOPORTDOCS is defined.
>
> please find attached a revised patch, including:
>
> - the update to 6.4.4.1
> - update to the new OPTIONS framework (s|NOPORTDOCS|!${PORTOPTIONS:MDOCS})
> - install man pages along with docs
> - fix wish and datadir paths in gpsman.tcl
>
> Approved?
The tinderbox build also defined NOPORTDATA. This variable makes little
sense, but you could support it in the do-install target (don't install
${PREFIX}/share/gpsman (aka ${DATADIR})).
Since you converted NOPORTDOCS, could you also add OPTIONS_DEFINE=DOCS?
Manpages are always installed I think. If they are optional they fall
under the MANPAGES option.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130923/e304ebdc/attachment.sig>
More information about the freebsd-ports
mailing list