Help in testing Basho Riak port

[Bryan Drewery]

On Fri, Sep 20, 2013 at 06:57:52PM +0100, Big Lebowski wrote:
> Hi list!
> 
> I've been working for couple last days on porting Basho Riak database
> (latest version 1.4.2) and finally I think it is ready to be presented:
> https://www.dropbox.com/s/2ztu2bdiip1u2un/riak.tgz

  MASTER_SITES=   http://s3.amazonaws.com/downloads.basho.com/riak/1.4/1.4.2/ \
		  http://downloads.basho.com.s3.amazonaws.com/riak/1.4/1.4.2/

Use ${PORTVERSION} instead of 1.4.2

  USES=           ${GMAKE}

Use 'gmake', not ${GMAKE} here.

Fails to build on 8.3 i386:

  db/version_set.cc:59: warning: this decimal constant is unsigned only in ISO C90
  db/version_set.cc:59: warning: this decimal constant is unsigned only in ISO C90
  db/version_set.cc:60: error: integer constant is too large for 'long' type
  db/version_set.cc:60: error: integer constant is too large for 'long' type
  db/version_set.cc:61: error: integer constant is too large for 'long' type
  db/version_set.cc:61: error: integer constant is too large for 'long' type
  db/version_set.cc:62: error: integer constant is too large for 'long' type
  db/version_set.cc:62: error: integer constant is too large for 'long' type
  table/filter_block.cc: In member function 'bool leveldb::FilterBlockReader::KeyMayMatch(uint64_t, const leveldb::Slice&)':
  table/filter_block.cc:112: warning: comparison between signed and unsigned integer expressions
  util/env_posix.cc: In constructor 'leveldb::<unnamed>::PosixEnv::PosixEnv()':
  util/env_posix.cc:788: warning: unused variable 'ts'


  gmake[1]: *** [libleveldb.so.1.9] Error 1
  gmake[1]: Leaving directory `/wrkdirs/usr/ports/databases/riak/work/riak-1.4.2/deps/eleveldb/c_src/leveldb'


Instead of bsd.port.pre.mk ... bsd.port.post.mk, use bsd.port.options.mk ...
bsd.port.mk. Although, it doesn't look like you even need that. Just use
bsd.port.mk at the end, no 2nd include.


Otherwise, good work. I will pkg-build test any updates you send out.

> 
> Please, grab the port and test it on anything you can, break it in any way
> possible, and comment on anything you see that's been done wrong - I am
> open to any suggestion on how to make it worthy candidate for send-pr with
> port submission.
> 
> Any help will be highly appreciated and will motivate me to port more cool
> software to FreeBSD! ;)
> 
> Kind regards,
> S.
> _______________________________________________
> freebsd-ports at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130920/d0083517/attachment.sig>