libc++ differences between 9.2 and 10.0

[Tijl Coosemans]

On Fri, 20 Sep 2013 15:01:58 +0930 Shane Ambler wrote:
> I'm Starting to look at fixing my ports to build on 10.0 and there
> appears to be a difference between 9.2 and 10.0 when it comes to using 
> libc++
> 
> The first port I am looking at is graphics/opencolorio. a patch was
> submitted (ports/182220) that works fine on 10.0 but it breaks 9.2 build
> when using clang with -
> error: no type named 'shared_ptr' in namespace 'std'
> 
> The patch is simple, just adding -
> 
> #elif __cplusplus >= 199711
> #include <memory>
> #define OCIO_SHARED_PTR std::shared_ptr
> #define OCIO_DYNAMIC_POINTER_CAST std::dynamic_pointer_cast
> 
> As far as I can see both 10.0 and 9.2 use the same contrib/libc++
> contents but I don't see why 9.2 isn't finding std::shared_ptr

Clang on 9.2 uses libstdc++ by default which doesn't define shared_ptr
in <memory>.

> The other thing is I don't think testing __cplusplus is the right way to
> go but don't see an alternative. __cplusplus is defined in clang
> irrespective of the library used so isn't really a reliable test.
> 
> Are there any defines to easily test for std::shared_ptr or is that a
> test I need to create for configure or cmake - has already been done?

The libc++ headers define _LIBCPP_VERSION so as long as at least one
standard header has been included before including OpenColorABI.h, which
seems to be the case, you can use #elif defined(_LIBCPP_VERSION).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130920/0b4ae5e5/attachment.sig>