Proposal: further OptionsNG improvements

[Baptiste Daroussin]

On Tue, Jun 18, 2013 at 11:27:08PM +0700, Alexey Dokuchaev wrote:
> On Tue, Jun 18, 2013 at 11:00:37PM +0700, Alexey Dokuchaev wrote:
> > Hi there,
> > 
> > Now as I understand old-skool OPTIONS knob support is removed, can we do
> > something about ugliness of newish OPTIONS_DEFINE[_arch]/OPTIONS_DEFAULT
> > [_arch] pair of knobs?
> > 
> > I am thinking about the following syntax (using now free-again OPTIONS
> > knob, instead of several OPTIONS_DEFINE/OPTIONS_DEFAULT definitions):
> > 
> >   OPTIONS=	FOO:on BAR ASM/i386,amd64:on,powerpc ...
> > 
> > Ditto for OPTIONS_RADIO et al.  This will also be kind of reminiscent to
> > existing USE_AUTOCONF and recently added USES knob.
> 	   ^^^^^^^^^^^^
> Should be USE_AUTOTOOLS of course, sorry.  Per-architecture syntax can be
> quite flexible, depeding on what's easier to parse:
> 
> 	ASM/i386,amd64:on,powerpc		or
> 	ASM/i386:off,amd64:on,powerpc:off	or
> 	ASM/powerpc,{i386,amd64}:on		etc.
> 
> ./danfe

Sorry it took time for me to reply, after we last talk about this, I thought a
lot about this, and while in principe I do like the idea, I have a couple of
concerns:
1: this reduces lots of flexibility we now have with the new options framework,
well at the least the patch should make sure it doesn't reduce it for instance,
it should work properly with:
OPTIONS_EXCLUDE and OPTIONS_SLAVE.

if should be able to handle properly the folowing situation:
OPTIONS_DEFINE= DOCS X11
OPTIONS_DEFINE_i386=	MYSQL PGSQL
OPTIONS_DEFINE_amd64=	MYSQL PGSQL
OPTIONS_DEFAULT_i386=	MYSQL
OPTIONS_DEFAULT_amd64=	PGSQL
OPTIONS_EXCLUDE_powerpc=	X11

This is things I haven't been able to imagine in a concise/understandable syntax
like the one you are proposing, if we are able to do it then fine for me :)

2: I'm concern about the parsing performance, not that I have tested anything,
but it just looks like it would be less performant for make(1) to parse properly
all this, this should be measured to at least know the inpact in the package
building clusters and index building boxes once everything will be converted.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130621/ed3cd4c1/attachment.sig>