CFT: building multimedia/vlc with clang on 9.1+

[Juergen Lock]

On Sun, Jan 20, 2013 at 12:12:03AM +0100, René Ladan wrote:
> On 19-01-2013 23:53, Juergen Lock wrote:
> > In article <50FB156A.5010003 at gmail.com> you write:
> >> On 19-01-2013 22:09, Juergen Lock wrote:
> [...]
> 
> >>
> >>> Index: Makefile
> >>> ===================================================================
> >>> RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
> >>> retrieving revision 1.312
> >>> diff -u -p -r1.312 Makefile
> >>> --- Makefile	12 Jan 2013 20:25:57 -0000	1.312
> >>> +++ Makefile	19 Jan 2013 20:45:39 -0000
> >>> @@ -679,9 +679,16 @@ IGNORE=		base clang version too old, set
> >>>  CONFIGURE_ARGS+=--enable-altivec # VLC's config script doesn't know to do this
> >>>  .endif
> >>>  
> >>> +# prefer clang on 9.1+
> >>> +.if (${OSVERSION} >= 901000) && exists(${DESTDIR}/usr/bin/clang)
> >>
> >> Not sure if this is the proper(TM) way to detect clang.
> >>> +CC=	clang
> >>> +CXX=	clang++
> >>> +CPP=	clang-cpp
> >>> +.else
> >>>  .if ${ARCH} == "i386"
> >>>  USE_GCC?=	4.6+ # sse/3dnow detection on i386 needs newer gcc
> >>
> >> See above, if on e.g. FreeBSD 12 the /usr/bin/clang file gets removed
> >> this makes the port always use GCC 4.6+
> >>
> > Hmm do you think this would happen?  We still had /usr/bin/gcc hardlinked
> > to /usr/bin/cc the entire time we used gcc...
> > 
> Not really, but it _could_ happen.
> 
Well should that happen we can just stop setting CC since clang
will be default anyway...

	Juergen