openssh-portable segmentation faults

[Bryan Drewery]

On 2/7/2013 5:50 PM, Dimitry Andric wrote:
> On 2013-02-08 00:16, Dimitry Andric wrote:
>> On 2013-02-07 22:14, Dewayne Geraghty wrote:
>> ...
>>> Bryan, Dimitry,
>>> Thank-you for your interest.
>>> Unfortunately we have no debugging tools on any of the machines. I'll
>>> build one today and reproduce.
> ...
>> Executive summary: we recently imported a strnvis() implementation from
>> NetBSD, which has differently ordered arguments from the strnvis()
>> implementation in OpenBSD.  When OpenSSH calls it with arguments ordered
>> in the way OpenBSD expects, the function segfaults.
> 
> And here is a patch, which works for me.  It simply disables use of
> libc's strnvis(), forcing the port to use its own bundled version.

Perfect thanks. This was the approach I was going to take as well, since
it has a bundled compatibility version already.

Fix Committed.

-- 
Regards,
Bryan Drewery
bdrewery at freenode/EFNet

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130207/5d947ecd/attachment.sig>