shells/bash-static fails to package/deinstall cleanly

[clutton]

On Thu, 2013-12-26 at 11:52 +0200, clutton wrote:
> On Thu, 2013-12-26 at 10:36 +0200, clutton wrote:
> > On Wed, 2013-12-25 at 23:52 -0800, Doug Barton wrote:
> > > Please don't remove people from the CC line. I copied the maintainer on 
> > > purpose.
> > > 
> > > On 12/25/2013 11:40 PM, clutton wrote:
> > > > On Wed, 2013-12-25 at 22:06 -0800, Doug Barton wrote:
> > > >> The problem is that the bash.1 and bashbugs.1 man pages do not get
> > > >> compressed, and therefore the package fails. If I add a MAN1 variable to
> > > >> the Makefile with those pages listed, it works.
> > > >>
> > > >> Doug
> > > >
> > > >  From https://wiki.freebsd.org/ports/StageDir
> > > >
> > > > MAN*/MANLANG/MLINKS now useless
> > > > manpage compression/uncompression is now automatically handled by the
> > > > framework if you use stagedir.
> > > 
> > > ... and yet, that's not what happened here. Hence the problem report.
> > > 
> > > > Take a look at my port: multimedia/ffmpegthumbnailer
> > > > I believe I did it right :)
> > > 
> > > It's not my port, which is why I CCed the maintainer.
> > > 
> > > Doug
> > 
> > It is the case, the bash port uses STAGE, bash-static doesn't and bash
> > static is slave port of bash. Try to remove NO_STAGE from
> > bash-static/Makefile.
> 
> Yeap, my guess was right. After removing NO_STAGE, I have man pages
> installed correctly.
> 
> ====> Compressing man pages (compress-man)
> ===>  Installing for bash-static-4.2.45_1
> ===>  Checking if shells/bash-static already installed
> ===>   Registering installation for bash-static-4.2.45_1
> Installing bash-static-4.2.45_1... done
> 
> 
> Do you still think that backward compatibility is a good thing for such
> a project like FreeBSD ports? I'd like to spend time doing real porting
> instead of dealing with something like that bug.
> 
> Many projects which were good from the beginning now are pieces of sheet
> because of backward compatibility, firefox jetpack sdk and xul show this
> clearly. I don't want to see FreeBSD ports in this list.
> 
> Please fill the pr.
> diff --git a/shells/bash-static/Makefile b/shells/bash-static/Makefile
> index f5063a0..363a823 100644
> --- a/shells/bash-static/Makefile
> +++ b/shells/bash-static/Makefile
> @@ -5,5 +5,4 @@ MASTERDIR=      ${.CURDIR}/../../shells/bash
> 
>  OPTIONS_SLAVE= STATIC
> 
> -NO_STAGE=      yes
>  .include "${MASTERDIR}/Makefile"

Actually don't. Do not fill the pr.

Ξ ~ → cat /usr/ports/shells/bash-static/Makefile 
# Created by: Emanuel Haupt <ehaupt at FreeBSD.org>
# $FreeBSD$

MASTERDIR=	${.CURDIR}/../../shells/bash

OPTIONS_SLAVE=	STATIC

.include "${MASTERDIR}/Makefile"

The whole port because of STATIC option?
It'll be better to move this thing to bash port and make it as an
option. Like zsh maintainer did.