miniupnpd not inserting pf rules

[krad]

cool i was tired so couldnt make the last step, i can confirm removing the
WITH makes the patch get applied



On 12 December 2013 14:34, Volodymyr Kostyrko <c.kworr at gmail.com> wrote:

> 11.12.2013 17:00, krad wrote:
>
>> I have being having some trouble/fun with miniupnpd, in that it didnt seem
>> to be inserting the rules into pf ( pfctl -sr -a miniupnpd
>> ). The rdr rules are inserted fine just not the firewall rules at the
>> rules
>> anchor. I think I have traced the problem down to the port build itself. I
>> have tested and reproduced it on a clean system on both 9.2 and 10 64bit
>> intel builds, but I would be good to have a sanity check make sure i have
>> not missed something before I raise a pr/bug report to the maintainer.
>>
>>
>> The problem lies with the extra_patch that isnt applied even if the
>> dialogue option is checked. Manually specifying it in the environment
>> doesn't work either
>>
>> ..if ${PORT_OPTIONS:MWITH_PF_ENABLE_FILTER_RULES}
>> EXTRA_PATCHES=  ${PATCHDIR}/pf_enable_filter_rules.patch
>>
>
> Man you are awesome! I had installed this one and thought there was some
> compatibility problems so I just thrashed it.
>
> In the above example please remove 'WITH_' portion and try to recheck. If
> this will clear things for you - fire up a pr with a patch.
>
> --
> Sphinx of black quartz, judge my vow.
>