redports.org No address record

[Fernando Apesteguía]

On Fri, Apr 12, 2013 at 10:42 PM, Tijl Coosemans <tijl at coosemans.org> wrote:

> On 2013-04-12 19:55, Fernando Apesteguía wrote:
> > On Fri, Apr 12, 2013 at 6:54 PM, Chris Rees <crees at freebsd.org> wrote:
> >
> >> On 12 April 2013 16:52, Fernando Apesteguía
> >> <fernando.apesteguia at gmail.com> wrote:
> >>> Hi,
> >>>
> >>> I'm getting a "No address record" error[1] trying to build cad/openvsp
> in
> >>> redports.
> >>> It builds fine in my local machine and I can access the URL with the
> >>> browser too.
> >>>
> >>> What am I missing?
> >>>
> >>> Thanks in advance.
> >>>
> >>> [1]
> >>>
> >>
> https://redports.org/~fernape/20130412153229-03742-113174/openvsp-2.2.3.log
> >>
> >> Network access is not allowed in any phase except the fetch phase.
> >>
> >
> > I understand, but I'm only accessing the network in that phase via the
> > do-fetch target, right?
> >
> >
> >>
> >> You need to add openvsp-2.2.3.tar.gz to DISTFILES-- are you using
> >> USE_GITHUB?
> >>
> >
> > I'm gonna need more help here :)
> >
> > The current version of the port (2.2.2) doesn't set DISTFILES. Is it
> > necessary?
> >
> > Secondly, I didn't know of the existence of USE_GITHUB.
> >
> > I suppose I should do something like this:
> >
> > USE_GITHUB=       yes
> > GH_ACCOUNT=     OpenVSP
> > GH_PROJECT=       OpenVSP
> > GH_TAG=                2.2.3
> > GH_COMMIT=        fb52aa2
> >
> >  and set MASTER_SITES = ${GITHUB_CLOUD}
> >
> > is that correct?
>
> Try the attached patch for 2.2.2.
>

I have a new patch based on the changes suggested by Tijl (thanks!). It
looks fine (port test reports no errors). I would like to submit the PR
based on this new patch. Do the committers  agree?

Thanks to all!
-------------- next part --------------
diff -ruN /usr/ports/cad/openvsp/Makefile cad/openvsp/Makefile
--- /usr/ports/cad/openvsp/Makefile	2013-03-22 21:06:14.000000000 +0100
+++ cad/openvsp/Makefile	2013-04-13 18:54:20.000000000 +0200
@@ -2,15 +2,13 @@
 # $FreeBSD: cad/openvsp/Makefile 314960 2013-03-22 20:06:14Z makc $
 
 PORTNAME=	openvsp
-PORTVERSION=	2.2.2
+PORTVERSION=	2.2.3
 CATEGORIES=	cad
-MASTER_SITES=	https://github.com/OpenVSP/OpenVSP/archive/
 
 MAINTAINER=	fernando.apesteguia at gmail.com
 COMMENT=	Create a 3D model of an aircraft defined by engineering parameters
 
 BUILD_DEPENDS=	${LOCALBASE}/lib/libopenNURBS.a:${PORTSDIR}/graphics/opennurbs
-
 LIB_DEPENDS=	pthread-stubs:${PORTSDIR}/devel/libpthread-stubs \
 		jpeg:${PORTSDIR}/graphics/jpeg \
 		drm:${PORTSDIR}/graphics/libdrm \
@@ -20,9 +18,15 @@
 		fontconfig:${PORTSDIR}/x11-fonts/fontconfig \
 		fltk:${PORTSDIR}/x11-toolkits/fltk \
 		xcb:${PORTSDIR}/x11/libxcb
-WRKSRC=		${WRKDIR}/OpenVSP-OpenVSP_${PORTVERSION}/src
 
-USES=		cmake
+USE_GITHUB=	yes
+GH_PROJECT=	OpenVSP
+GH_ACCOUNT=	${GH_PROJECT}
+GH_TAGNAME=	${GH_PROJECT}_${PORTVERSION}
+GH_COMMIT=	fb52aa2
+
+CMAKE_SOURCE_PATH=	${WRKSRC}/src
+USES=		cmake:outsource
 USE_DOS2UNIX=	yes
 USE_ICONV=	yes
 USE_XORG=	ice sm x11 xau xdamage xdmcp xext xfixes xft \
@@ -31,7 +35,7 @@
 USE_GNOME=	libxml2
 
 PORTEXAMPLES=	*
-INSTALL_PORTEXAMPLES=	@(cd ${WRKSRC}/../examples/ && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
+INSTALL_PORTEXAMPLES=	@(cd ${WRKSRC}/examples && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
 
 PLIST_FILES=	bin/vsp
 
@@ -39,14 +43,8 @@
 
 .include <bsd.port.options.mk>
 
-do-fetch:
-	if [ ! -f ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX} ]; then \
-		${FETCH_BINARY} -o ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX} \
-			${MASTER_SITES}OpenVSP_${PORTVERSION}${EXTRACT_SUFX}; \
-	fi
-
 do-install:
-	@${INSTALL_PROGRAM} ${WRKSRC}/vsp/vsp ${PREFIX}/bin
+	@${INSTALL_PROGRAM} ${BUILD_WRKSRC}/vsp/vsp ${PREFIX}/bin
 .if ${PORT_OPTIONS:MEXAMPLES}
 	@${MKDIR} ${EXAMPLESDIR}
 	@${INSTALL_PORTEXAMPLES}
diff -ruN /usr/ports/cad/openvsp/distinfo cad/openvsp/distinfo
--- /usr/ports/cad/openvsp/distinfo	2013-02-20 19:07:19.000000000 +0100
+++ cad/openvsp/distinfo	2013-04-13 18:53:43.000000000 +0200
@@ -1,2 +1,2 @@
-SHA256 (openvsp-2.2.2.tar.gz) = 93dd8978b568eb5726a9392308029b7b9967ae1af8c4033e8e8cba05f5a46e9b
-SIZE (openvsp-2.2.2.tar.gz) = 2921036
+SHA256 (openvsp-2.2.3.tar.gz) = 0ae143c31c09cd8bd93ead480c32343d0b360ef132e1ce5d3d2beec3457c7a63
+SIZE (openvsp-2.2.3.tar.gz) = 2921344
diff -ruN /usr/ports/cad/openvsp/files/patch-xmlvsp-CMakeLists.txt cad/openvsp/files/patch-xmlvsp-CMakeLists.txt
--- /usr/ports/cad/openvsp/files/patch-xmlvsp-CMakeLists.txt	2012-07-14 14:56:14.000000000 +0200
+++ cad/openvsp/files/patch-xmlvsp-CMakeLists.txt	2013-04-13 18:35:51.000000000 +0200
@@ -1,5 +1,5 @@
 --- /home/fernape/porting/openvsp/original/OpenVSP_2.0_community_src/src/xmlvsp/CMakeLists.txt	2012-04-04 21:03:54.000000000 +0200
-+++ xmlvsp/CMakeLists.txt	2012-04-04 20:29:08.000000000 +0200
++++ src/xmlvsp/CMakeLists.txt	2012-04-04 20:29:08.000000000 +0200
 @@ -2,7 +2,7 @@
  
  FIND_PACKAGE(LibXml2 REQUIRED)