Failed upgrade sudo-1.8.5.p3 to sudo-1.8.6.p3 running stable/9

[Wesley Shields]

On Wed, Sep 26, 2012 at 02:05:57PM -0700, David Wolfskill wrote:
> On Wed, Sep 26, 2012 at 04:59:28PM -0400, Wesley Shields wrote:
> > On Wed, Sep 26, 2012 at 04:43:57AM -0700, David Wolfskill wrote:
> > > This is a FreeBSD/i386 stable/9 system:
> > > 
> > > FreeBSD freebeast.catwhisker.org 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #485 240956M: Wed Sep 26 04:19:48 PDT 2012     root at freebeast.catwhisker.org:/usr/obj/usr/src/sys/GENERIC  i386
> > > 
> > > built with clang, but cc is gcc:
> > 
> > This is a failure on i386 only, which is why I didn't notice it. Would
> > you apply the patch available at [1] and let me know if it works. It
> > does build for me now that I built up a i386 environment.
> > 
> > [1]: http://people.freebsd.org/~wxs/sudo-ssp.diff
> > ....
> 
> Aye; builds & a trivial test:
> 
> d134(9.1-P)[1] sudo id
> Password:
> uid=0(root) gid=0(wheel) groups=0(wheel),5(operator)
> d134(9.1-P)[2] 
> 
> works. :-}

My original patch did not build correctly with clang. I've just
committed r304961 which works on both i386 and under clang.

-- WXS