tk85 Port Maintenance

Joseph a Nagy Jr jnagyjr1978 at gmail.com
Wed Oct 31 17:43:17 UTC 2012


On 10/31/12 11:55, Pietro Cerutti wrote:
> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
<snip>
>> New diff[0], undoing some of the earlier changes even though portlint
>> complains:
>>
>> portlint ~/port-maintenance/tk85/
>> WARN: Makefile: unless this is a master port, COMMENT has to be set by
>> "=", not by "?=".
> 
> This *is* a master port, so it's ok to have COMMENT?=
> 
>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
> 
> This should be fixed as portlint suggests.
> 
>> WARN: Makefile: no port directory
>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
>> listed in LIB_DEPENDS.
> 
> I would try and use USE_TCL instead of LIB_DEPENDS here
> 
>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
>> Xft.2 unless it is really necessary.
> 
> This should be fixed as portlint suggests.
> 
>> 0 fatal errors and 4 warnings found.
>>
>> [0]: http://pastebin.com/apf1Y9H0
> 
> I'll have a look at it on Friday, thanks!
> 
> 

Going ahead to make those changes, old pastebin link is defunct.

New diff with all changes:
http://pastebin.com/iwhpXfcp

-- 
Yours in Christ,

Joseph A Nagy Jr
"Whoever loves instruction loves knowledge, But he who hates correction
is stupid." -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 549 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20121031/285cd245/attachment.sig>


More information about the freebsd-ports mailing list