FreeBSD 10.0-CURRENT/amd64 r242305: www/apache22: setfib: NO: invalid FIB (max 0)

[Stefan Esser]

Am 30.10.2012 09:28, schrieb O. Hartmann:
> Am 10/29/12 14:57, schrieb Rainer Hurling:
>> Am 29.10.2012 14:19 (UTC+1) schrieb O. Hartmann:
>>> Hello world.
>>> 
>>> With the most recent FreeBSD 10.0-CURRENT/amd64 r242305, CLAN
>>> buildworld and with libc++/c++11 compiled, I can not start the
>>> Apache 2.22 webserver anymore and receive this error on all
>>> boxes:
>>> 
>>> 
>>> service apache22 restart Performing sanity check on apache22
>>> configuration: Syntax OK apache22 not running? (check
>>> /var/run/httpd.pid). Performing sanity check on apache22
>>> configuration: Syntax OK Starting apache22. setfib: NO: invalid
>>> FIB (max 0) /usr/local/etc/rc.d/apache22: WARNING: failed to
>>> start apache22
>> 
>> I don't know, if this is intended. But the following entry in 
>> /etc/rc.conf helps restarting the server:
>> 
>> apache22_fib=0
>> 
>> This is mentioned in the updated rc.conf(5).
>> 
> 
> Thanks. This helped and seems to resolve the problem.

Yes, but does not fix the underlying problem.

r242184 added setfib(1) support to rc.subr and assumes, that any
non-blank value is a FIB number.

But the RC script for apache sets "apache_fib" to "NO" if it does
not contain a FIB number.

This leads to a comamnd "setfib -F NO apache" and setfib complains
about the non-zero value.

I assume that the apache RC script should be modified to not pass
apache22_fib="NO" for the case of no FIB. OTOH, the code in rc.subr
could be changed to accept "NO" as equivalent to an empty value of
the FIB variable.

Setting "apache22_fib=0" just hides the problem. It does not harm,
but the default of not specifying a FIB should just work.

Regards, STefan

PS: I'll open a PR ...